From: Kisub Choe <kisub.choe.0x1@gmail.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Kisub Choe <kisub.choe.0x1@gmail.com>,
gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: replace msleep(1)
Date: Mon, 23 Jun 2025 23:35:27 +0900 [thread overview]
Message-ID: <aFlmL0DtydfsbFl0@rpi4B8Gs> (raw)
In-Reply-To: <efa56904-eabf-4493-b064-652d02839c6b@suswa.mountain>
On Mon, Jun 23, 2025 at 01:54:01PM +0300, Dan Carpenter wrote:
> On Sun, Jun 22, 2025 at 08:28:16AM +0900, Kisub Choe wrote:
> > changed msleep to usleep_range to
> >
> > Adhere to Linux kernel coding style.
> > Reported by checkpatch:
> >
> > WARNING: msleep < 20ms can sleep for up to 20ms;
> > see function description of msleep().
> >
> > Signed-off-by: Kisub Choe <kisub.choe.0x1@gmail.com>
>
> This type of change needs to be tested before it can be merged.
>
> regards,
> dan carpenter
>
Thank you for feedback.
I understand that this type of change should be tested due to its impact
on time-sensitive behavior.
However, I currently don't have access to any device that uses this
driver.
Please let me know how you'd suggest proceeding in this case.
Regards,
Kisub Choe.
next prev parent reply other threads:[~2025-06-23 14:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-21 23:28 [PATCH] staging: rtl8723bs: replace msleep(1) Kisub Choe
2025-06-23 10:54 ` Dan Carpenter
2025-06-23 14:35 ` Kisub Choe [this message]
2025-06-23 15:16 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFlmL0DtydfsbFl0@rpi4B8Gs \
--to=kisub.choe.0x1@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).