linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Danilo Krummrich <dakr@kernel.org>
To: Matthew Maurer <mmaurer@google.com>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"Sami Tolvanen" <samitolvanen@google.com>,
	"Timur Tabi" <ttabi@nvidia.com>,
	"Benno Lossin" <lossin@kernel.org>,
	linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org
Subject: Re: [PATCH v7 3/6] rust: types: Support &'static and &'static mut ForeignOwnable
Date: Wed, 25 Jun 2025 10:44:21 +0200	[thread overview]
Message-ID: <aFu25UGNjpdSVd6_@cassiopeiae> (raw)
In-Reply-To: <20250624-debugfs-rust-v7-3-9c8835a7a20f@google.com>

On Tue, Jun 24, 2025 at 11:25:22PM +0000, Matthew Maurer wrote:
> +    fn into_foreign(self) -> *mut Self::PointedTo {
> +        self as *const _ as _

Please prefer

	core::ptr::from_ref(self).cast_mut()

instead.

> +    }

  reply	other threads:[~2025-06-25  8:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-24 23:25 [PATCH v7 0/6] rust: DebugFS Bindings Matthew Maurer
2025-06-24 23:25 ` [PATCH v7 1/6] rust: debugfs: Bind DebugFS directory creation Matthew Maurer
2025-06-24 23:25 ` [PATCH v7 2/6] rust: debugfs: Bind file creation for long-lived Display Matthew Maurer
2025-06-24 23:25 ` [PATCH v7 3/6] rust: types: Support &'static and &'static mut ForeignOwnable Matthew Maurer
2025-06-25  8:44   ` Danilo Krummrich [this message]
2025-06-25  8:46     ` Danilo Krummrich
2025-06-24 23:25 ` [PATCH v7 4/6] rust: debugfs: Support arbitrary owned backing for File Matthew Maurer
2025-06-24 23:25 ` [PATCH v7 5/6] rust: debugfs: Support format hooks Matthew Maurer
2025-06-24 23:25 ` [PATCH v7 6/6] rust: samples: Add debugfs sample Matthew Maurer
2025-06-25  6:22 ` [PATCH v7 0/6] rust: DebugFS Bindings Dirk Behme

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aFu25UGNjpdSVd6_@cassiopeiae \
    --to=dakr@kernel.org \
    --cc=a.hindborg@kernel.org \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=gary@garyguo.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=mmaurer@google.com \
    --cc=ojeda@kernel.org \
    --cc=rafael@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=samitolvanen@google.com \
    --cc=tmgross@umich.edu \
    --cc=ttabi@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).