From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1562A2DC34C for ; Tue, 8 Jul 2025 16:39:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751992801; cv=none; b=GJGukE7jNGTS5lCUdM0R5Z7d8k7V6L1ehzx5B00Gym2ZwgdVmtyqabK5u/WbY0wfUnYTQNCJGqjXHBcfiYKSCHKE8Xjw3juHoCzZCpEfcHCWHcPy4sqguJJz5FiLbCbhsPwqGROXdweSMLxCrxcoNBQYGw8RjSNDUdrQf/U9yQA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751992801; c=relaxed/simple; bh=XrRWcUPg0gmCaugL4AqdIxVcA/fgtzY2T3UQnwDgL/M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OMKxE2R9JggND2Fj8vq8pStaAipfibDW8gTZHBb9G55H8poWJwwSu4jKCqtuhB0YYKFDMy2vbbK49zGcRvYf3XPkf+TQmMPFgeCkY3ntd6s7H4SygxqIOwEJknU4cxU9zL8U+yqjma16uxMLU2XH/apeZstBUHQ7CyT821WjRKA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=JfXMuSrx; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JfXMuSrx" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2350fc2591dso763535ad.1 for ; Tue, 08 Jul 2025 09:39:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751992799; x=1752597599; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=C3QtUO+mox2CABNnuiEmoJosMc/S7Dy/CWYLY5RAJ/U=; b=JfXMuSrxtKdJzjetM3T0RjVe28BEdl27Mn+RHHMxIHHEBnDvavq/vcOuYUz3AttdBz iiOiW5UwBG1uVxBwIchXDErAf7Vv9/bhi1gBFxoI9V7o3cCOSgxlFYKFm+m6eOwsDd6w TuDF/CkeXMagHhHVRSc73kmS0JGEvlnT2kvB5+GBMFUCZ9oCjpMSBAsbme8wgNMK7xfn iUBirGjhZn1Ccc74K2U25UsmmXG+Xr5xHMC188E9omo7ySiFRtbongxC/d0frF9pZiSB 2mXcGaYvwBhn4bJfqBClpwthzWwhzwnUlyIC2Zkx/r9AKlTVxlbN6ZkuTGzR9+ENMhLi pxQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751992799; x=1752597599; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=C3QtUO+mox2CABNnuiEmoJosMc/S7Dy/CWYLY5RAJ/U=; b=k1AKsqzVxgHh2EAGwlrBvTU4jgq7ENFxS5kivxZH0PRICI50aw1VnQAD59J7U8Vonj UQAnDM0CJIcvJSdtg0BIVQbzzzPWxzg/u2Aw0gmUMVlcIprQpIZ3jWE+zMYpJq2CldYj 844H1e0yaanqp4kkGUuREyeXF2dVMcp44MC+SoKn/9mEsoEvbIsPs9rt4BUboH0V8HV2 /AIplhXVekWC7ZJMdFGYkdyoQLc/F3w17+w63eKBAN5pDzpeduI1U6TzmgyPCiegfy0C oesca7DMdYPqCcQ7FGw5IyUkfTAjWVLe2vm4IwP5S9ZLY5ogWZ3hyexQm3rvdt3zgfEc 4YuQ== X-Forwarded-Encrypted: i=1; AJvYcCUuvBN4Ye6CtZHphyl7xSvRRmrlWdIfbGc0cft0ZajkEvIL1RRdyj96KDTxDiI5yhyVYBeNsOq//s+Jnng=@vger.kernel.org X-Gm-Message-State: AOJu0Yy1zTZnilZbkcCNgf3yI3swW8EGeOfN1nIY9uAgvm3OoqAuMHze YJBA2d6fuOJmTgPqg09pgiifSZRVKBkqRgFzbHlZ+Q4JgXdT4SYGHCybucx7HCGECRY= X-Gm-Gg: ASbGncs98wv3t1N0YGBPkPBHgmhnB7BsNrOxJGXYHXoJGWSJeVD7kzNFkxpMax/NS5/ TkTmolqnb041J11bsFjYSIlXHdhINO3zogfuh2pB7EOa4cD/2z/ehY7mVFR8q3UH+llx5qItdvD rwvR46SomOPM/WEcyRaR4+Lup7OLE248cdRVrmSWq6wHxjhsD2XhIqnmq43zJrK+5hPW9q6LJfb VOI7pth74ZWvQyuIjL5zjyF869WocpqWw7ay3LpW511S6nfjTHBxXSJ6S81Aqb6mO63vnIaAT6i QpuTVmZlI6sSKTRYSb5N1f7jyq/8cJQkrps8K6gQW43aFibRSjafzcOPnLXt+uaFtg== X-Google-Smtp-Source: AGHT+IFj8nhxMS1GDmay5meyEAJ4wmQBHnfoxVzxfQ/DjVHpn1xffU3YRdB8/FjZpsJTq7vNTw85+g== X-Received: by 2002:a17:902:f74e:b0:23d:d290:705 with SMTP id d9443c01a7336-23dd2900d0amr27843715ad.3.1751992798824; Tue, 08 Jul 2025 09:39:58 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:c5cf:9364:ea5e:99f1]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23c8431e1c8sm123626055ad.42.2025.07.08.09.39.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Jul 2025 09:39:58 -0700 (PDT) Date: Tue, 8 Jul 2025 10:39:55 -0600 From: Mathieu Poirier To: "Peng Fan (OSS)" Cc: Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Frank Li , Daniel Baluta , Iuliana Prodan , linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [PATCH v3 3/5] remoteproc: imx_rproc: Add support for i.MX95 Message-ID: References: <20250625-imx95-rproc-1-v3-0-699031f5926d@nxp.com> <20250625-imx95-rproc-1-v3-3-699031f5926d@nxp.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250625-imx95-rproc-1-v3-3-699031f5926d@nxp.com> On Wed, Jun 25, 2025 at 10:23:29AM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > Add imx_rproc_cfg_imx95_m7 and address(TCM and DDR) mapping. > Add i.MX95 of_device_id entry. > > Reviewed-by: Daniel Baluta > Signed-off-by: Peng Fan > --- > drivers/remoteproc/imx_rproc.c | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index b1a117ca5e5795554b67eb7092db2a25fc7de13b..c226f78c84ad180c69804116d6cfcab19db6aaa5 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -73,6 +73,10 @@ > > #define IMX_SC_IRQ_GROUP_REBOOTED 5 > > +/* Must align with System Manager Firmware */ > +#define IMX95_M7_CPUID 1 > +#define IMX95_M7_LMID 1 Any reason those aren't set in the device tree? Thanks, Mathieu > + > /** > * struct imx_rproc_mem - slim internal memory structure > * @cpu_addr: MPU virtual address of the memory region > @@ -126,6 +130,18 @@ struct imx_rproc { > u32 flags; > }; > > +static const struct imx_rproc_att imx_rproc_att_imx95_m7[] = { > + /* dev addr , sys addr , size , flags */ > + /* TCM CODE NON-SECURE */ > + { 0x00000000, 0x203C0000, 0x00040000, ATT_OWN | ATT_IOMEM }, > + > + /* TCM SYS NON-SECURE*/ > + { 0x20000000, 0x20400000, 0x00040000, ATT_OWN | ATT_IOMEM }, > + > + /* DDR */ > + { 0x80000000, 0x80000000, 0x50000000, 0 }, > +}; > + > static const struct imx_rproc_att imx_rproc_att_imx93[] = { > /* dev addr , sys addr , size , flags */ > /* TCM CODE NON-SECURE */ > @@ -372,6 +388,14 @@ static const struct imx_rproc_dcfg imx_rproc_cfg_imx93 = { > .method = IMX_RPROC_SMC, > }; > > +static const struct imx_rproc_dcfg imx_rproc_cfg_imx95_m7 = { > + .att = imx_rproc_att_imx95_m7, > + .att_size = ARRAY_SIZE(imx_rproc_att_imx95_m7), > + .method = IMX_RPROC_SM, > + .cpuid = IMX95_M7_CPUID, > + .lmid = IMX95_M7_LMID, > +}; > + > static int imx_rproc_start(struct rproc *rproc) > { > struct imx_rproc *priv = rproc->priv; > @@ -1301,6 +1325,7 @@ static const struct of_device_id imx_rproc_of_match[] = { > { .compatible = "fsl,imx8qm-cm4", .data = &imx_rproc_cfg_imx8qm }, > { .compatible = "fsl,imx8ulp-cm33", .data = &imx_rproc_cfg_imx8ulp }, > { .compatible = "fsl,imx93-cm33", .data = &imx_rproc_cfg_imx93 }, > + { .compatible = "fsl,imx95-cm7", .data = &imx_rproc_cfg_imx95_m7 }, > {}, > }; > MODULE_DEVICE_TABLE(of, imx_rproc_of_match); > > -- > 2.37.1 >