From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0202B268683 for ; Wed, 9 Jul 2025 04:42:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752036149; cv=none; b=US4r4rxA4xyo2B430KT5rc+c7ESe0APpHdIMfq6R5255bEtrl4DKa6trKEC6/EARvfd4VH71wASz4+tmKYkKix1KstSot+kh/BNB3pLxq4va0yRCYIpqwTa2RNeYyLKzwUyy/K2kbRNx7wuMrnt9HyrNXb/fRIrO5FvCIdHiAUg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752036149; c=relaxed/simple; bh=sWTCjw7yV66pBVAAsh/JHklRYDUJqSx7zwbyy/gm3qg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UfSEGRuRtestUAp6p3KathSOND4Z9EjCKsqSYyIHYGx5xGMX3ifJqRWk/5t50Vz/rMH/7VQBej+hIExHPS68ahUn3outIM/SUXk7eUyCV9Uu7IZoeA3U66lFGEus7OF4XhFghRWxh6BenzG3hUIwd8tCdv9mLqDLAXvKffNsXQo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1uZMdH-0004mH-4L; Wed, 09 Jul 2025 06:42:11 +0200 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uZMdF-007WaS-0X; Wed, 09 Jul 2025 06:42:09 +0200 Received: from ore by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1uZMdF-009pDy-03; Wed, 09 Jul 2025 06:42:09 +0200 Date: Wed, 9 Jul 2025 06:42:08 +0200 From: Oleksij Rempel To: Jun Miao Cc: kuba@kernel.org, oneukum@suse.com, qiang.zhang@linux.dev, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: usb: enable the work after stop usbnet by ip down/up Message-ID: References: <20250708081653.307815-1-jun.miao@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250708081653.307815-1-jun.miao@intel.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Hi Jun, please resend this patch with the name [PATCH net-next] and add all related people suggested by scripts/get_maintainer.pl. ./scripts/get_maintainer.pl drivers/net/usb/usbnet.c Oliver Neukum (maintainer:USB "USBNET" DRIVER FRAMEWORK) Andrew Lunn (maintainer:NETWORKING DRIVERS) "David S. Miller" (maintainer:NETWORKING DRIVERS) Eric Dumazet (maintainer:NETWORKING DRIVERS) Jakub Kicinski (maintainer:NETWORKING DRIVERS) Paolo Abeni (maintainer:NETWORKING DRIVERS) netdev@vger.kernel.org (open list:USB "USBNET" DRIVER FRAMEWORK) linux-usb@vger.kernel.org (open list:USB NETWORKING DRIVERS) linux-kernel@vger.kernel.org (open list) Best Regards, Oleksij On Tue, Jul 08, 2025 at 04:16:53PM +0800, Jun Miao wrote: > From: Zqiang > > Oleksij reported that: > The smsc95xx driver fails after one down/up cycle, like this: > $ nmcli device set enu1u1 managed no > $ p a a 10.10.10.1/24 dev enu1u1 > $ ping -c 4 10.10.10.3 > $ ip l s dev enu1u1 down > $ ip l s dev enu1u1 up > $ ping -c 4 10.10.10.3 > The second ping does not reach the host. Networking also fails on other interfaces. > > Enable the work by replacing the disable_work_sync() with cancel_work_sync(). > > [Jun Miao: completely write the commit changelog] > > Fixes: 2c04d279e857 ("net: usb: Convert tasklet API to new bottom half workqueue mechanism") > Reported-by: Oleksij Rempel > Tested-by: Oleksij Rempel > Signed-off-by: Zqiang > Signed-off-by: Jun Miao > --- > drivers/net/usb/usbnet.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c > index 9564478a79cc..6a3cca104af9 100644 > --- a/drivers/net/usb/usbnet.c > +++ b/drivers/net/usb/usbnet.c > @@ -861,14 +861,14 @@ int usbnet_stop (struct net_device *net) > /* deferred work (timer, softirq, task) must also stop */ > dev->flags = 0; > timer_delete_sync(&dev->delay); > - disable_work_sync(&dev->bh_work); > + cancel_work_sync(&dev->bh_work); > cancel_work_sync(&dev->kevent); > > /* We have cyclic dependencies. Those calls are needed > * to break a cycle. We cannot fall into the gaps because > * we have a flag > */ > - disable_work_sync(&dev->bh_work); > + cancel_work_sync(&dev->bh_work); > timer_delete_sync(&dev->delay); > cancel_work_sync(&dev->kevent); > > -- > 2.32.0 > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |