From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D262C23CB for ; Mon, 30 Jun 2025 01:02:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751245380; cv=none; b=DmH3ODwjX90lXcGNRJDf0fNXhpt/oxy3wb2n/o06geiCmjn10jItDPvpCpQtzrYvmLe8VeeY5UfTZ9qT4rYuTtSxw/AeRh3+yo8eujhwT3UyGVoaaH0JK8HNIpHH46a+fbYBcdIMXqbn5zdNRDJYO0hvSA74wDiACMt7DL3e9NA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751245380; c=relaxed/simple; bh=uSTgHYx4C4kBqf1HLkMQN6sxONduD5cTV2ZutL1GEdQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XUgMu+ddKA/Hs+Q8JKQ3z5yNC1svPgZjXwE4uNNA88SSs3t+7kfY6APC9UMGC+xtMUrcwIe6DAEHRmVO3KmQBEwgNO7R7j9DamekEf6JXdf4HnuhA7G4oiQOxu222sTXgEc1wI/Q8rOi6d42/JFF43WHcucDmjMf7X0DPbEytjw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=DbU/Y52z; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="DbU/Y52z" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-742c7a52e97so4119008b3a.3 for ; Sun, 29 Jun 2025 18:02:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1751245378; x=1751850178; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=lHC8G37kFyRpeOrqLUvPPIOdjSNN7VBUfiKPLfHZcIs=; b=DbU/Y52zsp2ru5YoOCxlHgr73TRes0Me/DuRHSM/biPCB9lBfrtYZ49ki2x/jvPxYr JqG31xL3DjWyS6/rV/3yQ1g7n+yOxKBjyhH0c/E2fNa0Xt72Aqcop0w4ZmKPJ+OnRzMW sstMpGXs1FipaBp24tX6pz8LJPFI6TnP6fEFd/zYufp/vbgMCbVJYZ4rfv0i3j4TYSC/ If+lCYIdeQD71KmDtW2/41KKnwAykv8NTcXf0RJVBBg4/lv8z175SfpQ8VW+fmTazhqs K2Uav3a8j2uuoye/FwTduqtI1Kububx4CpXfzM50KH1hJ+VX080UVPNLGXwLMyRFayhC Nc2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751245378; x=1751850178; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lHC8G37kFyRpeOrqLUvPPIOdjSNN7VBUfiKPLfHZcIs=; b=r8VBiTU2FL/4UignkZTVmeq0EaUAR7G9rtrFrKdDJRLSK65bIeoQPzcmGqbss5+mn8 9FPoktfzBvjlYiFaap+nXY8S4OFZgBMB8DWkyJWXFctswGrGzi0ZQ1w6p29FGxjtQG90 DDJYAzWWZ0cdzij0MDsbFkNSrSX9HbOWcSZDbyXYjutK65Mz1uuMz1sUQCeU9QylvXbB hu8tep6JeaCssVcRGHBL9i3SCHe9mkJo65G0NhiIpVLYs7YKfrerjqM7aHCIBoXH/N3P zypFrt7OqyieeyO2VKP8uOzk/bvWiSSSgyhl+YAsa50SznDs7X/6C7vvKtWGtL6uVfFD 0UQw== X-Forwarded-Encrypted: i=1; AJvYcCXFcoAuhfsofRPqZkgtDSehFkCmxmJXTirOHMXyoZXqP0/SdP6M/gsU3YCWMPWHmaQ3LWwY4MxYWmIhcA8=@vger.kernel.org X-Gm-Message-State: AOJu0Yz1qcXRjblLvx8jLZXDC4JiaADVxWhxypHU241nf9ogUjQr5s8J jXiuD6F29X4G8Ri3A7Jrg+ANmOBYFurZS+xnzDxFV4bgDYK2w0/8yuI+BIGQ6ize+cQ= X-Gm-Gg: ASbGncsyoESUjkUfeca9u7/8facugVBwaziJenjQ31ovueQhL2SSvl+SgOd47Wg7Cbi I9vziMVFFshlk5L3GJlJSayIQJOjywaQ1npoybSdlk96/MZzQXgV0Upf0Uc1nyGf1HcibZqdvgd +0ozbwofwdwLl70fVz9sGCKg4jsEGdiMx7cdYb/hKhftQKVmQOAh5wdy+aJ1qLReAKh3u8q+2u0 9F8SiBYEMSx8zKRynaBXPtx24zG0k/MNNbZHU75JmDeii2hq7MRD6/M3GDSyFnTPdCOGN3TQnt0 lA/9bx9I+Ph7BFXNZAEO4wsb8/hGXOqeXeOvZm711CUxJ3rXa4onqj356CnWmLIVu5uML0aI4p4 NSEn3B4+fDm4yJ4l4f8Tx6g== X-Google-Smtp-Source: AGHT+IEm7pC4jQ5wCTQ49NFxc+IKcZR+PXZpSdBzcwoRcmqxvtnLCfqF+Cj6519xtp9p1Fwj8KqI/w== X-Received: by 2002:a05:6a00:17a8:b0:747:ab61:e4fa with SMTP id d2e1a72fcca58-74af6f08162mr14240794b3a.14.1751245378059; Sun, 29 Jun 2025 18:02:58 -0700 (PDT) Received: from dev-linux (syn-076-088-115-008.res.spectrum.com. [76.88.115.8]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-74af56d91edsm8034737b3a.140.2025.06.29.18.02.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Jun 2025 18:02:57 -0700 (PDT) Date: Sun, 29 Jun 2025 18:02:54 -0700 From: Sukrut Bellary To: Andy Shevchenko Cc: David Lechner , Jonathan Cameron , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matti Vaittinen , Nuno =?utf-8?B?U8Oh?= , Andy Shevchenko , Angelo Compagnucci , Nishanth Menon , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 4/5] iio: adc: ti-adc128s052: Add lower resolution devices support Message-ID: References: <20250614091504.575685-1-sbellary@baylibre.com> <20250614091504.575685-5-sbellary@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Sun, Jun 29, 2025 at 09:06:47AM +0300, Andy Shevchenko wrote: > On Sun, Jun 29, 2025 at 2:30 AM David Lechner wrote: > > > > On 6/28/25 6:09 PM, Sukrut Bellary wrote: > > > On Sat, Jun 14, 2025 at 09:45:43PM +0300, Andy Shevchenko wrote: > > >> On Sat, Jun 14, 2025 at 12:15 PM Sukrut Bellary wrote: > > >>> > > >>> The adcxx communicates with a host processor via an SPI/Microwire Bus > > >>> interface. The device family responds with 12-bit data, of which the LSB bits > > >>> are transmitted by the lower resolution devices as 0. > > >>> The unavailable bits are 0 in LSB. > > >>> Shift is calculated per resolution and used in scaling and raw data read. > > >>> > > >>> Lets reuse the driver to support the family of devices with name > > >>> ADCS, where > > >> > > >> I believe it's incorrect, i.e. it's something like ...S, where > > >> is something you need to clarify, and is definitely a speed > > >> in kSPS. > > >> > > > Thank you for the review. > > > I am not sure about the last s in . > > > It could be TI's silicon spins versioning. > > > I couldn't find any information about it in any of the datasheets. > > > I can drop the last s or mark it as and specify the first two as > > > maximum speed. > > > > > I have a hunch that the last digit has to do with pinout/number of > > power supplies. adc128s052 has two supplies V_A and V_D while the > > others only have V_A. > > > > If this sounds vaguely familiar, it is because it was discussed > > today in this thread [1] that Jonathan CC'ed you in. :-) > > With all this being said, please, switch to

and describe

, > but with the caveat that the

is empirically deducted based on what > community observes. > > > [1]: https://lore.kernel.org/linux-iio/20250628162910.1256b220@jic23-huawei/ > Ok, sure. I will use this in v5. > -- > With Best Regards, > Andy Shevchenko