From: Richard Cochran <richardcochran@gmail.com>
To: Wen Gu <guwen@linux.alibaba.com>
Cc: Vadim Fedorenko <vadim.fedorenko@linux.dev>,
Andrew Lunn <andrew@lunn.ch>,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, xuanzhuo@linux.alibaba.com,
dust.li@linux.alibaba.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] ptp: add Alibaba CIPU PTP clock driver
Date: Mon, 30 Jun 2025 06:42:38 -0700 [thread overview]
Message-ID: <aGKUThtBfPvlWL35@hoboy.vegasvil.org> (raw)
In-Reply-To: <ea85f778-a2d4-439c-abbd-2a8ecea0e928@linux.alibaba.com>
On Mon, Jun 30, 2025 at 07:23:49PM +0800, Wen Gu wrote:
> In ptp_clock.c, ops.clock_settime() is assigned to ptp_clock_settime(),
> and it will call ptp->info->settime64() without checks. So I think these
> 'return -EOPNOTSUPP' functions are needed. Did I miss something?
Right, for the essential clock related callbacks, stubs are expected
by the ptp class layer.
Some of the newer, non-essential clock methods do indeed check the
function pointer, simply to accommodate existing drivers.
Thanks,
Richard
next prev parent reply other threads:[~2025-06-30 13:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-27 7:29 [PATCH net-next v2] ptp: add Alibaba CIPU PTP clock driver Wen Gu
2025-06-27 7:46 ` Andrew Lunn
2025-06-30 9:04 ` Wen Gu
2025-06-27 7:57 ` Andrew Lunn
2025-06-27 10:59 ` Vadim Fedorenko
2025-06-30 11:23 ` Wen Gu
2025-06-30 13:42 ` Richard Cochran [this message]
2025-06-30 12:45 ` Wen Gu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aGKUThtBfPvlWL35@hoboy.vegasvil.org \
--to=richardcochran@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dust.li@linux.alibaba.com \
--cc=edumazet@google.com \
--cc=guwen@linux.alibaba.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vadim.fedorenko@linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox