Re: [PATCH v1 20/29] mm: convert "movable" flag in page->mapping to a page flag

Harry Yoo
2025-07-02T11:55:58Z

On Mon, Jun 30, 2025 at 03:00:01PM +0200, David Hildenbrand wrote:
> Instead, let's use a page flag. As the page flag can result in
> false-positives, glue it to the page types for which we
> support/implement movable_ops page migration.
>
> The flag reused by PageMovableOps() might be sued by other pages, so
> warning in case it is set in page_has_movable_ops() might result in
> false-positive warnings.
>
> Reviewed-by: Zi Yan <ziy@nvidia.com>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---

LGTM,
Reviewed-by: Harry Yoo <harry.yoo@oracle.com>

With a question: is there any reason to change the page flag
operations to use atomic bit ops? (.e.g, using SetPageMovableOps instead
of __SetPageMovableOps)

--
Cheers,
Harry / Hyeonggon