From: Johan Hovold <johan@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, Alex Elder <elder@kernel.org>,
greybus-dev@lists.linaro.org
Subject: Re: [PATCH v2] staging: greybus: gbphy: fix up const issue with the match callback
Date: Tue, 1 Jul 2025 14:20:13 +0200 [thread overview]
Message-ID: <aGPSfRSTDXsNNp1P@hovoldconsulting.com> (raw)
In-Reply-To: <2025070115-reoccupy-showy-e2ad@gregkh>
On Tue, Jul 01, 2025 at 01:06:16PM +0200, Greg Kroah-Hartman wrote:
> gbphy_dev_match_id() should be taking a const pointer, as the pointer
> passed to it from the container_of() call was const to start with (it
> was accidentally cast away with the call.) Fix this all up by correctly
> marking the pointer types.
>
> Cc: Johan Hovold <johan@kernel.org>
> Cc: Alex Elder <elder@kernel.org>
> Cc: greybus-dev@lists.linaro.org
> Fixes: d69d80484598 ("driver core: have match() callback in struct bus_type take a const *")
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> v2: - add Fixes: line as pointed out by Johan
> - don't make gbphy_dev const, it's not needed, as pointed out by
> Johan
Reviewed-by: Johan Hovold <johan@kernel.org>
prev parent reply other threads:[~2025-07-01 12:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-01 11:06 [PATCH v2] staging: greybus: gbphy: fix up const issue with the match callback Greg Kroah-Hartman
2025-07-01 12:20 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aGPSfRSTDXsNNp1P@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox