Re: [PATCH v1 24/29] mm/page-flags: remove folio_mapping_flags()

Lorenzo Stoakes
2025-07-01T13:07:39Z

On Mon, Jun 30, 2025 at 03:00:05PM +0200, David Hildenbrand wrote:
> It's unused and the page counterpart is gone, so let's remove it.
>
> Reviewed-by: Zi Yan <ziy@nvidia.com>
> Signed-off-by: David Hildenbrand <david@redhat.com>

LGTM, so:

Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>

> ---
> include/linux/page-flags.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h
> index f539bd5e14200..b42986a578b71 100644
> --- a/include/linux/page-flags.h
> +++ b/include/linux/page-flags.h
> @@ -718,11 +718,6 @@ PAGEFLAG_FALSE(VmemmapSelfHosted, vmemmap_self_hosted)
> #define PAGE_MAPPING_KSM (PAGE_MAPPING_ANON | PAGE_MAPPING_ANON_KSM)
> #define PAGE_MAPPING_FLAGS (PAGE_MAPPING_ANON | PAGE_MAPPING_ANON_KSM)
>
> -static __always_inline bool folio_mapping_flags(const struct folio *folio)
> -{
> - return ((unsigned long)folio->mapping & PAGE_MAPPING_FLAGS) != 0;
> -}
> -
> static __always_inline bool folio_test_anon(const struct folio *folio)
> {
> return ((unsigned long)folio->mapping & PAGE_MAPPING_ANON) != 0;
> --
> 2.49.0
>