From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f201.google.com (mail-pf1-f201.google.com [209.85.210.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B2BD2701AE for ; Thu, 10 Jul 2025 13:56:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752155802; cv=none; b=MXB8CQnrQu82q4X3ORMtZdagVdikfdOR0zL4PBMnqBsHzSgDD7B+PRPz+aE5jksuNdVOmfxd6FaU79RpZGFgzyafO9X361P7Hom7D4B1Q100+L6YJ+bHY55N2MtBFdRP58U2BTKmUxk39N53OLJ9LE1C1ATm1MfhVRADpiLW3EM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752155802; c=relaxed/simple; bh=5DtOimy0T+XI5TFEUlM8L85pT4fht3/s31oyvwu1R7A=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=JR6xZgC/o9J54ZHlzQbFO6Cr+AX6mCRZY3ScdBPGZCJB8A5k8f+gQe2+HpaLytMicZWSot97boC1pJEFMvYiUzlEvoxqR0a8eO78yiLdLdom5iZF6HoZkKOSeh3c5/c1SwRwbWUYxl/10cDPuR0+mAZV3j1M1JWfKaGUBRdno8E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Sk7vll0S; arc=none smtp.client-ip=209.85.210.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Sk7vll0S" Received: by mail-pf1-f201.google.com with SMTP id d2e1a72fcca58-7491814d6f2so1215743b3a.3 for ; Thu, 10 Jul 2025 06:56:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1752155800; x=1752760600; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=jdivoy2i5Gr9aD8xwW1tsvlEITdtVn9BeGlg1mVQmjw=; b=Sk7vll0SXqBIdEQp0GLBdsoo65qqS+hg07GoZaKsXnnASUiREsb6Vsz5ddpc2CDGJb lNQ3+yU6qWvAGRTW0grLTihs9kLyNyrH4Fe3jOPLhyRZ/rxZd9MSaqt6BgwrwW/4ZeE2 Cbo5x28WpBwpl5AmmxLs7voa/5AE6eWT2gQsq6rRHlwclbvQGnOOADrbsohNyeEjsrlJ HR2tnMfzhPbskVE2MGkGl4XcyrsEIRsKp4FPQym2sc/5gg0PtyVRdtY0r0/YE3TPy8UV h5mJBIp2KJ3HT/R3j3o3qewS32AO4w+Y3TquZ2A0M1CeHswSMBbnMYfCt+QL4oUU4DX9 CR2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752155800; x=1752760600; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jdivoy2i5Gr9aD8xwW1tsvlEITdtVn9BeGlg1mVQmjw=; b=qia1hMpx8zrx817Y8Shq4gHQ90PqMwMtiOGP3hNPJLKGuIGPvChMtnLDYtgYDSOAzb +ZINk2ihLMpr4RDIKVcpy18UsZy/TkaZNi9nT/7odsHiXPdK1dImQ/7ZDe7tpILu78In RMR3Yrezd7AzETh71ac4eqxPabFCuIH1AV8nMgSd5xc0kEil78UscdHtCELnQA/YtPtm poBm2T053gzX2h6Ir5cRs8G3axk5Ek2Qe9YUhDp5TUr0EM7njD3Iym+2W6TKhptvnuX0 fpZadCJiJTmI6909BiRilKqvKCIpH9Aogw1UGeEGt7nTLYxG3JYx5cK8I78jBNL0aPlx 8mIg== X-Forwarded-Encrypted: i=1; AJvYcCWOMe4+HlVM4/WdAWO+YRrncE6abMpxqeZxfWY9Fo5sYzwE07PvvYzNmNfK3OmoHEZQHejbFTuVT2H21J8=@vger.kernel.org X-Gm-Message-State: AOJu0YwLRuhkH+iT5qiJ8YS0m8YuY5Bmt89JcSUF1l8coMnhXvaSTqpV X5YwCyv8+j0vNP2ghKoHVit4lWF8Zzr70Sn3IW2Imyd7IC61mAocvdbHuebLnRHi7l8EujwxUYm xqY/FnA== X-Google-Smtp-Source: AGHT+IFQLmoe4r0uGjszcjS65GBUmZL9XmUcIofKbdPbRYIZxHVIlOanHmYbmqpsneWEQZcfGa1zcK869ME= X-Received: from pfbfi6.prod.google.com ([2002:a05:6a00:3986:b0:746:247f:7384]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:3c8c:b0:749:ad1:ac8a with SMTP id d2e1a72fcca58-74ea6684ae5mr10003879b3a.11.1752155800315; Thu, 10 Jul 2025 06:56:40 -0700 (PDT) Date: Thu, 10 Jul 2025 06:56:38 -0700 In-Reply-To: <20250710112902.GCaG-j_l-K6LYRzZsb@fat_crate.local> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250522233733.3176144-1-seanjc@google.com> <20250522233733.3176144-4-seanjc@google.com> <20250710112902.GCaG-j_l-K6LYRzZsb@fat_crate.local> Message-ID: Subject: Re: [PATCH v3 3/8] x86, lib: Add WBNOINVD helper functions From: Sean Christopherson To: Borislav Petkov Cc: Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, Paolo Bonzini , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, dri-devel@lists.freedesktop.org, Kevin Loughlin , Tom Lendacky , Kai Huang , Ingo Molnar , Zheyun Shen , Mingwei Zhang , Francesco Lavra Content-Type: text/plain; charset="us-ascii" On Thu, Jul 10, 2025, Borislav Petkov wrote: > On Thu, May 22, 2025 at 04:37:27PM -0700, Sean Christopherson wrote: > > diff --git a/arch/x86/lib/cache-smp.c b/arch/x86/lib/cache-smp.c > > index 079c3f3cd32c..1789db5d8825 100644 > > --- a/arch/x86/lib/cache-smp.c > > +++ b/arch/x86/lib/cache-smp.c > > @@ -19,3 +19,14 @@ void wbinvd_on_all_cpus(void) > > on_each_cpu(__wbinvd, NULL, 1); > > } > > EXPORT_SYMBOL(wbinvd_on_all_cpus); > > + > > +static void __wbnoinvd(void *dummy) > > +{ > > + wbnoinvd(); > > +} > > + > > +void wbnoinvd_on_all_cpus(void) > > +{ > > + on_each_cpu(__wbnoinvd, NULL, 1); > > +} > > +EXPORT_SYMBOL(wbnoinvd_on_all_cpus); > > If there's no particular reason for the non-GPL export besides being > consistent with the rest - yes, I did the change for wbinvd_on_all_cpus() but > that was loooong time ago - I'd simply make this export _GPL. Yeah, AFAIK, no reason other than consistency. GPL it.