From: Petr Mladek <pmladek@suse.com>
To: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>,
"John Ogness" <john.ogness@linutronix.de>,
"Dan Carpenter" <dan.carpenter@linaro.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Kees Cook <kees@kernel.org>,
"Gustavo A . R . Silva" <gustavoars@kernel.org>,
David Gow <davidgow@google.com>, Arnd Bergmann <arnd@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH 0/3] printk: KUnit: Followup fixes for the new KUnit test
Date: Thu, 10 Jul 2025 17:29:37 +0200 [thread overview]
Message-ID: <aG_cYSfhXfxQoKco@pathway.suse.cz> (raw)
In-Reply-To: <20250702095157.110916-1-pmladek@suse.com>
On Wed 2025-07-02 11:51:54, Petr Mladek wrote:
> Hi,
>
> this patchset puts together some followup fixes for the new KUnit test
> which were discussed on several locations.
>
> 1st patch:
>
> + adds a comment exaplaing why the test ignores pr_reserve() failures.
>
> + was proposed at https://lore.kernel.org/r/aFUiQESkXjFIGqez@pathway.suse.cz
>
> + Thomas Weißschuh added into v4 of the original patch but I have already
> comitted v3 in the meantime, see
> https://lore.kernel.org/r/20250620-printk-ringbuffer-test-v4-1-8df873f1f3e0@linutronix.de
>
>
> 2nd patch:
>
> + dynamically allocates a cpu bitmap to make the code safe even on systems
> with many CPUs.
>
> + v1 was set by Arnd Bergmann but it had some problems, see
> https://lore.kernel.org/r/20250620192554.2234184-1-arnd@kernel.org
>
> + This version just integreates the proposed fixes from
> https://lore.kernel.org/r/aFkuqaFn3BOvsPT-@pathway.suse.cz
>
>
> 3rd patch:
>
> + stores "size" instead on "len" in struct prbtest_rbdata so that
> is can be used to check code sanity by __counted_by(size).
>
> + fixes https://lore.kernel.org/r/eaea66b9-266a-46e7-980d-33f40ad4b215@sabinyo.mountain
>
> + it is based on the idea from Thomas Weißschuh, see
> 20250626082605-c5fbbb88-f6cc-4659-bea0-a283cdb58e81@linutronix.de
JFYI, the 1st and 3rd patch has been committed into printk/linux.git,
branch rework/ringbuffer-kunit-test.
These two patches were reviewed by Thomas and John and were accepted.
The 2nd patch is independent and has an issue. I am going to send
an update separately.
Best Regards,
Petr
prev parent reply other threads:[~2025-07-10 15:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-02 9:51 [PATCH 0/3] printk: KUnit: Followup fixes for the new KUnit test Petr Mladek
2025-07-02 9:51 ` [PATCH 1/3] printk: ringbuffer: Explain why the KUnit test ignores failed writes Petr Mladek
2025-07-04 11:28 ` John Ogness
2025-07-02 9:51 ` [PATCH 2/3] printk: kunit: support offstack cpumask Petr Mladek
2025-07-02 20:28 ` Nathan Chancellor
2025-07-08 14:24 ` Petr Mladek
2025-07-08 14:48 ` Arnd Bergmann
2025-07-09 11:36 ` Petr Mladek
2025-07-09 12:53 ` Thomas Weißschuh
2025-07-10 13:51 ` Petr Mladek
2025-07-10 14:08 ` Arnd Bergmann
2025-09-02 13:55 ` Petr Mladek
2025-07-03 14:36 ` kernel test robot
2025-07-02 9:51 ` [PATCH 3/3] printk: kunit: Fix __counted_by() in struct prbtest_rbdata Petr Mladek
2025-07-04 11:41 ` John Ogness
2025-07-02 15:48 ` [PATCH 0/3] printk: KUnit: Followup fixes for the new KUnit test Thomas Weißschuh
2025-07-10 15:29 ` Petr Mladek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aG_cYSfhXfxQoKco@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=davidgow@google.com \
--cc=gustavoars@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=kees@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=thomas.weissschuh@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox