Re: [PATCH v6 2/6] rust: irq: add flags module

Daniel Almeida
2025-07-12T16:27:37Z

Hi Alice,

> On 4 Jul 2025, at 04:42, Alice Ryhl <aliceryhl@google.com> wrote:
>
> On Fri, Jul 04, 2025 at 08:14:11AM +0200, Daniel Sedlak wrote:
>> Hi Daniel,
>>
>> On 7/3/25 9:30 PM, Daniel Almeida wrote:
>>> +/// Flags to be used when registering IRQ handlers.
>>> +///
>>> +/// They can be combined with the operators `|`, `&`, and `!`.
>>> +#[derive(Clone, Copy, PartialEq, Eq)]
>>> +pub struct Flags(u64);
>>
>> Why not Flags(u32)? You may get rid of all unnecessary casts later, plus
>> save some extra bytes.
>
> It looks like the C methods take an `unsigned long`. In that case, I'd
> probably write the code to match that.
>
> pub struct Flags(c_ulong);
>
> and git rid of the cast when calling bindings::request_irq.
>
> As for all the constants in this file, maybe it would be nice with a
> private constructor that uses the same type as bindings to avoid the
> casts?
>
> impl Flags {
> const fn new(value: u32) -> Flags {
> ...
> }
> }

Sure, but what goes here? This has to be "value as c_ulong” anyways so it
doesn’t really reduce the number of casts.

We should probably switch to Flags(u32) as Daniel Sedlak suggested. Then
it’s a matter of casting once for bindings::request_irq().

— Daniel