Re: [PATCH v6 6/6] rust: pci: add irq accessors

Danilo Krummrich
2025-07-04T18:19:41Z

On Fri, Jul 04, 2025 at 07:56:56AM +0000, Alice Ryhl wrote:
> On Thu, Jul 03, 2025 at 04:30:04PM -0300, Daniel Almeida wrote:
> > These accessors can be used to retrieve a irq::Registration or a
> > irq::ThreadedRegistration from a pci device. Alternatively, drivers can
> > retrieve an IrqRequest from a bound PCI device for later use.
> >
> > These accessors ensure that only valid IRQ lines can ever be registered.
> >
> > Signed-off-by: Daniel Almeida <daniel.almeida@collabora.com>
>
> Same question as patch 5.

Here we don't do a lookup of the IRQ number by name, yet the API asks for the
name used for the IRQ registration, hence it needs a static lifetime, since the
pointer is directly stored in struct irqaction. It's accessed by trace events
for instance.

> With that answered:
> Reviewed-by: Alice Ryhl <aliceryhl@google.com>