Re: [PATCH v6 2/6] rust: irq: add flags module

Miguel Ojeda
2025-07-04T09:31:49Z

On Fri, Jul 4, 2025 at 8:14 AM Daniel Sedlak <daniel@sedlak.dev> wrote:
>
> Why not Flags(u32)? You may get rid of all unnecessary casts later, plus
> save some extra bytes.

Yeah, avoiding the casts would be nice -- however it is done.

On the patch: it wouldn't hurt to add an example for each of the
operators too. Even better if it is a common use case of each (say,
for `|`, a common combination of these flags).

(By the way, the use of the `into_inner()` name here is another one we
will want to discuss for the new naming guidelines table.)

Thanks!

Cheers,
Miguel