linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-renesas-soc@vger.kernel.org"
	<linux-renesas-soc@vger.kernel.org>,
	"linux-stm32@st-md-mailman.stormreply.com"
	<linux-stm32@st-md-mailman.stormreply.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	"biju.das.au" <biju.das.au@gmail.com>
Subject: Re: [PATCH net-next] net: stmmac: dwmac-renesas-gbeth: Add PM suspend/resume callbacks
Date: Sun, 6 Jul 2025 11:06:21 +0100	[thread overview]
Message-ID: <aGpKncEeZTifSlA2@shell.armlinux.org.uk> (raw)
In-Reply-To: <TY3PR01MB113460004F6A57B3AAD77E86E864CA@TY3PR01MB11346.jpnprd01.prod.outlook.com>

On Sun, Jul 06, 2025 at 08:45:14AM +0000, Biju Das wrote:
> Hi Russell King,
> 
> FYI, The above testing is done with rootFS mounted on SD card.
> 
> But when I mount rootFS on NFS, after wakeup, I am not able to contact the NFS server.
> 
> The below patch makes it to work[1].
> Not sure, why the original code is failing if the rootFS is mounted on NFS?

It would be good to understand exactly what is going on there.

As stmmac sets mac_managed_pm to true, which is propagated to phylib,
this means the mdiobus suspend/resume will be no-ops, as the MAC driver
needs to do everything necessar to resume the PHY.

Is your PHY losing power over suspend/resume?

Maybe phylink_prepare_resume() needs to call phy_init_hw() as well,
like mdio_bus_phy_resume() does?

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

  parent reply	other threads:[~2025-07-06 10:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-05 17:03 [PATCH net-next] net: stmmac: dwmac-renesas-gbeth: Add PM suspend/resume callbacks Biju Das
2025-07-05 19:31 ` Russell King (Oracle)
2025-07-05 20:26   ` Biju Das
2025-07-06  8:45     ` Biju Das
2025-07-06  9:55       ` Biju Das
2025-07-06 10:10         ` Russell King (Oracle)
2025-07-06 14:06           ` Biju Das
2025-07-06 10:06       ` Russell King (Oracle) [this message]
2025-07-06 10:17         ` Biju Das
2025-07-16 18:19 ` Biju Das
2025-07-16 19:36   ` Biju Das
2025-07-16 19:26 ` Lad, Prabhakar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aGpKncEeZTifSlA2@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=alexandre.torgue@foss.st.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=biju.das.au@gmail.com \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=geert+renesas@glider.be \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).