From: Christoph Hellwig <hch@infradead.org>
To: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
Cc: ntfs3@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org,
syzbot+a5d1c9dfa91705cd2f6d@syzkaller.appspotmail.com,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Subject: Re: [PATCH] Revert "fs/ntfs3: Replace inode_trylock with inode_lock"
Date: Mon, 7 Jul 2025 06:00:07 -0700 [thread overview]
Message-ID: <aGvE1_yre9ayskxu@infradead.org> (raw)
In-Reply-To: <20250707124738.6764-1-almaz.alexandrovich@paragon-software.com>
On Mon, Jul 07, 2025 at 02:47:38PM +0200, Konstantin Komarov wrote:
> This reverts commit 69505fe98f198ee813898cbcaf6770949636430b.
>
> Make lock acquiring conditional to avoid the deadlock.
This is not a very useful commit message for a locking change.
Please explain the problem this solves, and why the original reason
for the locking change isn't valid any more, or less important than
the newly arising issue.
next prev parent reply other threads:[~2025-07-07 13:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-07 12:47 [PATCH] Revert "fs/ntfs3: Replace inode_trylock with inode_lock" Konstantin Komarov
2025-07-07 13:00 ` Christoph Hellwig [this message]
2025-07-07 13:44 ` Lorenzo Stoakes
2025-07-08 7:57 ` [PATCH v2] " Konstantin Komarov
2025-07-09 14:16 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aGvE1_yre9ayskxu@infradead.org \
--to=hch@infradead.org \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=ntfs3@lists.linux.dev \
--cc=syzbot+a5d1c9dfa91705cd2f6d@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).