Re: [PATCH v2 1/2] clk: thead: th1520-ap: Correctly refer the parent of osc_12m

[Drew Fustini <fustini@kernel.org>]

On Thu, Jul 10, 2025 at 09:21:34AM +0000, Yao Zi wrote:
> The "osc_12m" fixed factor clock refers the external oscillator by
> setting clk_parent_data.fw_name to osc_24m, which is obviously wrong
> since no clock-names property is allowed for compatible
> thead,th1520-clk-ap.
> 
> Refer the oscillator as parent by index instead.
> 
> Fixes: ae81b69fd2b1 ("clk: thead: Add support for T-Head TH1520 AP_SUBSYS clocks")
> Signed-off-by: Yao Zi <ziyao@disroot.org>
> ---
>  drivers/clk/thead/clk-th1520-ap.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/thead/clk-th1520-ap.c b/drivers/clk/thead/clk-th1520-ap.c
> index ebfb1d59401d..42feb4bb6329 100644
> --- a/drivers/clk/thead/clk-th1520-ap.c
> +++ b/drivers/clk/thead/clk-th1520-ap.c
> @@ -582,7 +582,14 @@ static const struct clk_parent_data peri2sys_apb_pclk_pd[] = {
>  	{ .hw = &peri2sys_apb_pclk.common.hw }
>  };
>  
> -static CLK_FIXED_FACTOR_FW_NAME(osc12m_clk, "osc_12m", "osc_24m", 2, 1, 0);
> +static struct clk_fixed_factor osc12m_clk = {
> +	.div		= 2,
> +	.mult		= 1,
> +	.hw.init	= CLK_HW_INIT_PARENTS_DATA("osc_12m",
> +						   osc_24m_clk,
> +						   &clk_fixed_factor_ops,
> +						   0),
> +};
>  
>  static const char * const out_parents[] = { "osc_24m", "osc_12m" };
>  
> -- 
> 2.50.0

Reviewed-by: Drew Fustini <fustini@kernel.org>

Thanks for fixing this. osc_12m now appears under osc_24m in
clk_summary.

Drew