From: Baoquan He <bhe@redhat.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: kexec@lists.infradead.org, LKML <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Mario Limonciello <mario.limonciello@amd.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH v1 2/2] kexec_core: Drop redundant pm_restore_gfp_mask() call
Date: Fri, 11 Jul 2025 14:17:55 +0800 [thread overview]
Message-ID: <aHCskzYNOG5WNltA@MiWiFi-R3L-srv> (raw)
In-Reply-To: <1949230.tdWV9SEqCh@rjwysocki.net>
On 07/10/25 at 03:12pm, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> Drop the direct pm_restore_gfp_mask() call from the KEXEC_JUMP flow in
> kernel_kexec() because it is redundant. Namely, dpm_resume_end()
> called beforehand in the same code path invokes that function and
> it is sufficient to invoke it once.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
> kernel/kexec_core.c | 1 -
> 1 file changed, 1 deletion(-)
LGTM,
Acked-by: Baoquan He <bhe@redhat.com>
>
> --- a/kernel/kexec_core.c
> +++ b/kernel/kexec_core.c
> @@ -1136,7 +1136,6 @@
> Resume_devices:
> dpm_resume_end(PMSG_RESTORE);
> Resume_console:
> - pm_restore_gfp_mask();
> console_resume_all();
> thaw_processes();
> Restore_console:
>
>
>
next prev parent reply other threads:[~2025-07-11 6:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-10 13:08 [PATCH v1 0/2] kexec_core: Fix and cleanup for the KEXEC_JUMP flow Rafael J. Wysocki
2025-07-10 13:10 ` [PATCH v1 1/2] kexec_core: Fix error code path in " Rafael J. Wysocki
2025-07-11 6:16 ` Baoquan He
2025-07-11 9:29 ` Rafael J. Wysocki
2025-07-10 13:12 ` [PATCH v1 2/2] kexec_core: Drop redundant pm_restore_gfp_mask() call Rafael J. Wysocki
2025-07-11 6:17 ` Baoquan He [this message]
2025-07-11 11:15 ` [PATCH v1 0/2] kexec_core: Fix and cleanup for the KEXEC_JUMP flow Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aHCskzYNOG5WNltA@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dwmw2@infradead.org \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).