From: Andreas Klinger <ak@it-klinger.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: jic23@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, lars@metafoo.de,
javier.carrasco.cruz@gmail.com, mazziesaccount@gmail.com,
arthur.becker@sentec.com, perdaniel.olsson@axis.com,
mgonellabolduc@dimonoff.com, muditsharma.info@gmail.com,
clamor95@gmail.com, emil.gedenryd@axis.com,
devicetree@vger.kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/3] iio: light: add support for veml6046x00 RGBIR color sensor
Date: Mon, 14 Jul 2025 10:21:27 +0200 [thread overview]
Message-ID: <aHS-B5KmBKX72OZc@mail.your-server.de> (raw)
In-Reply-To: <aDTMSwhodZQLzZ4q@smile.fi.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1019 bytes --]
Hi Andy,
many thanks for the thorough review. One comment below.
Andy Shevchenko <andriy.shevchenko@linux.intel.com> schrieb am Mo, 26. Mai 23:17:
> > +/**
> > + * struct veml6046x00_data - Private data of driver.
> > + * @regmap: Regmap definition of sensor.
> > + * @trig: Industrial-IO trigger.
> > + * @rf: Regmap field of configuration.
> > + */
> > +struct veml6046x00_data {
> > + struct regmap *regmap;
> > + struct iio_trigger *trig;
> > + struct veml6046x00_rf rf;
>
> Does pahole agree on the choice of the layout?
This is the output of pahole:
struct veml6046x00_data {
struct regmap * regmap; /* 0 4 */
struct iio_trigger * trig; /* 4 4 */
struct veml6046x00_rf rf; /* 8 20 */
/* size: 28, cachelines: 1, members: 3 */
/* last cacheline: 28 bytes */
};
I don't see anything wrong or did i miss something?
Best regards,
Andreas
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2025-07-14 8:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-26 8:50 [PATCH v5 0/3] iio:light: add driver for veml6046x00 RGBIR color sensor Andreas Klinger
2025-05-26 8:50 ` [PATCH v5 1/3] dt-bindings: iio: light: veml6046x00: add " Andreas Klinger
2025-05-26 8:50 ` [PATCH v5 2/3] iio: light: add support for veml6046x00 RGBIR " Andreas Klinger
2025-05-26 20:17 ` Andy Shevchenko
2025-07-14 8:21 ` Andreas Klinger [this message]
2025-07-15 7:50 ` Andy Shevchenko
2025-05-31 17:20 ` Jonathan Cameron
2025-05-26 8:50 ` [PATCH v5 3/3] MAINTAINER: add maintainer for veml6046x00 Andreas Klinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aHS-B5KmBKX72OZc@mail.your-server.de \
--to=ak@it-klinger.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arthur.becker@sentec.com \
--cc=clamor95@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=emil.gedenryd@axis.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=mgonellabolduc@dimonoff.com \
--cc=muditsharma.info@gmail.com \
--cc=perdaniel.olsson@axis.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).