From: Christoph Hellwig <hch@infradead.org>
To: Sergey Bashirov <sergeybashirov@gmail.com>
Cc: Chuck Lever <chuck.lever@oracle.com>,
Christoph Hellwig <hch@infradead.org>,
Jeff Layton <jlayton@kernel.org>, NeilBrown <neil@brown.name>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Konstantin Evtushenko <koevtushenko@yandex.com>
Subject: Re: [PATCH v2 2/3] NFSD: Fix last write offset handling in layoutcommit
Date: Wed, 16 Jul 2025 04:16:07 -0700 [thread overview]
Message-ID: <aHeJ9zBd3msrwOGf@infradead.org> (raw)
In-Reply-To: <20250715153319.37428-3-sergeybashirov@gmail.com>
On Tue, Jul 15, 2025 at 06:32:19PM +0300, Sergey Bashirov wrote:
> The data type of loca_last_write_offset is newoffset4 and is switched
> on a boolean value, no_newoffset, that indicates if a previous write
> occurred or not. If no_newoffset is FALSE, an offset is not given.
> This means that client does not try to update the file size. Thus,
> server should not try to calculate new file size and check if it fits
> into the segment range. See RFC 8881, section 12.5.4.2.
>
> Sometimes the current incorrect logic may cause clients to hang when
> trying to sync an inode. If layoutcommit fails, the client marks the
> inode as dirty again.
>
> Fixes: 9cf514ccfacb ("nfsd: implement pNFS operations")
>
> Co-developed-by: Konstantin Evtushenko <koevtushenko@yandex.com>
Nit: The tag should directly follow the Fixes line without whitespaces.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2025-07-16 11:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-15 15:32 [PATCH v2 0/3] NFSD: Fix last write offset handling in layoutcommit Sergey Bashirov
2025-07-15 15:32 ` [PATCH v2 1/3] NFSD: Minor cleanup in layoutcommit processing Sergey Bashirov
2025-07-15 15:32 ` [PATCH v2 2/3] NFSD: Fix last write offset handling in layoutcommit Sergey Bashirov
2025-07-16 11:16 ` Christoph Hellwig [this message]
2025-07-15 15:32 ` [PATCH v2 3/3] NFSD: Minor cleanup in layoutcommit decoding Sergey Bashirov
2025-07-16 11:16 ` Christoph Hellwig
2025-07-15 16:11 ` [PATCH v2 0/3] NFSD: Fix last write offset handling in layoutcommit Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aHeJ9zBd3msrwOGf@infradead.org \
--to=hch@infradead.org \
--cc=Dai.Ngo@oracle.com \
--cc=chuck.lever@oracle.com \
--cc=jlayton@kernel.org \
--cc=koevtushenko@yandex.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=sergeybashirov@gmail.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).