From: Tejun Heo <tj@kernel.org>
To: "Michal Koutný" <mkoutny@suse.com>
Cc: Tiffany Yang <ynaffit@google.com>,
linux-kernel@vger.kernel.org, John Stultz <jstultz@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Stephen Boyd <sboyd@kernel.org>,
Anna-Maria Behnsen <anna-maria@linutronix.de>,
Frederic Weisbecker <frederic@kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Pavel Machek <pavel@kernel.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Chen Ridong <chenridong@huawei.com>,
kernel-team@android.com, Jonathan Corbet <corbet@lwn.net>,
cgroups@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [RFC PATCH v2] cgroup: Track time in cgroup v2 freezer
Date: Thu, 17 Jul 2025 07:05:14 -1000 [thread overview]
Message-ID: <aHktSgmh-9dyB7bz@slm.duckdns.org> (raw)
In-Reply-To: <5rm53pnhpdeqljxqywh26gffh6vlyb5j5s6pzxhv52odhkl4fm@o6p7daoponsn>
Hello,
On Thu, Jul 17, 2025 at 02:56:13PM +0200, Michal Koutný wrote:
...
> > + cgroup.freeze.stat
>
> With the given implementation (and use scenario), this'd better exposed
> in
> cgroup.freeze.stat.local
>
> I grok the hierarchical summing would make little sense and it'd make
> implementaion more complex. With that I'm thinking about formulation:
>
> Cumulative time that cgroup has spent between freezing and
> thawing, regardless of whether by self or ancestor cgroups. NB
> (not) reaching "frozen" state is not accounted here.
I wonder what hierarchical summing would look like for this. It's absolute
time interval measurement and I'm not sure whether summing up the
descendants' durations is the best way to go about it. ie. Should it be the
total duration any of the descendants are freezing or should it be sum of
the freezing durations of all descendants?
Thanks.
--
tejun
next prev parent reply other threads:[~2025-07-17 17:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-14 5:00 [RFC PATCH v2] cgroup: Track time in cgroup v2 freezer Tiffany Yang
2025-07-17 12:56 ` Michal Koutný
2025-07-17 13:52 ` Chen Ridong
2025-07-17 17:06 ` Tejun Heo
2025-07-22 22:41 ` Tiffany Yang
2025-07-22 22:27 ` Tiffany Yang
2025-07-17 17:05 ` Tejun Heo [this message]
2025-07-18 8:20 ` Michal Koutný
2025-07-18 9:26 ` Chen Ridong
2025-07-18 13:58 ` cpu.stat in core or cpu controller (was Re: [RFC PATCH v2] cgroup: Track time in cgroup v2 freezer) Michal Koutný
2025-07-19 2:01 ` Chen Ridong
2025-07-19 16:27 ` Tejun Heo
2025-07-22 9:01 ` Chen Ridong
2025-07-22 11:54 ` Michal Koutný
2025-07-23 1:28 ` Chen Ridong
2025-07-25 1:08 ` Tejun Heo
2025-07-25 1:54 ` Chen Ridong
2025-07-22 22:16 ` [RFC PATCH v2] cgroup: Track time in cgroup v2 freezer Tiffany Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aHktSgmh-9dyB7bz@slm.duckdns.org \
--to=tj@kernel.org \
--cc=anna-maria@linutronix.de \
--cc=cgroups@vger.kernel.org \
--cc=chenridong@huawei.com \
--cc=corbet@lwn.net \
--cc=frederic@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=jstultz@google.com \
--cc=kernel-team@android.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkoutny@suse.com \
--cc=pavel@kernel.org \
--cc=rafael@kernel.org \
--cc=roman.gushchin@linux.dev \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
--cc=ynaffit@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).