From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Zhen Ni <zhen.ni@easystack.cn>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs/adfs: bigdir: Restore EIO errno return when checkbyte mismatch
Date: Fri, 1 Aug 2025 22:20:19 +0100 [thread overview]
Message-ID: <aI0vk_rEGGApi6Vi@shell.armlinux.org.uk> (raw)
In-Reply-To: <20250801192200.GR222315@ZenIV>
On Fri, Aug 01, 2025 at 08:22:00PM +0100, Al Viro wrote:
> As it is, commit message fails to explain anything other than "smatch
> has been involved in catching this one". If you want to mention that,
> sure, but it's on the same level as "so-and-so told me this place
> looks fishy" - by all means, credit the contribution. Reported-by/
> caught-by/actually quoting smatch warning somewhere in the message -
> up to you, but that shouldn't be the entirety of commit message ;-)
Agree with everything you've said.
FWIW, the patch is definitely correct, but the commit text should
also have:
Fixes: d79288b4f61b ("fs/adfs: bigdir: calculate and validate directory checkbyte")
as that introduced the bug.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2025-08-01 21:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-01 9:38 [PATCH] fs/adfs: bigdir: Restore EIO errno return when checkbyte mismatch Zhen Ni
2025-08-01 13:25 ` Markus Elfring
2025-08-01 19:22 ` Al Viro
2025-08-01 21:20 ` Russell King (Oracle) [this message]
2025-08-05 7:30 ` [PATCH v2] " Zhen Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aI0vk_rEGGApi6Vi@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=zhen.ni@easystack.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).