* [PATCH v2] clk: spacemit: ccu_pll: fix error return value in recalc_rate callback
@ 2025-07-23 5:29 Akhilesh Patil
2025-07-25 2:36 ` Stephen Boyd
0 siblings, 1 reply; 2+ messages in thread
From: Akhilesh Patil @ 2025-07-23 5:29 UTC (permalink / raw)
To: mturquette, sboyd, dlan, heylenay, elder, inochiama, akhilesh,
robh, krzk+dt, conor+dt, heylenay, paul.walmsley, palmer, aou,
alex
Cc: linux-clk, linux-riscv, spacemit, linux-kernel, unicornxdotw,
jszhang, zhangmeng.kevin, akhileshpatilvnit, skhan
Return 0 instead of -EINVAL if function ccu_pll_recalc_rate() fails to
get correct rate entry. Follow .recalc_rate callback documentation
as mentioned in include/linux/clk-provider.h for error return value.
Signed-off-by: Akhilesh Patil <akhilesh@ee.iitb.ac.in>
Fixes: 1b72c59db0add ("clk: spacemit: Add clock support for SpacemiT K1 SoC")
Reviewed-by: Haylen Chu <heylenay@4d2.org>
Reviewed-by: Alex Elder <elder@riscstar.com>
---
v1 --> v2:
- Add missing Fixes: tag
- Carry forward Reviewed-by tags
---
drivers/clk/spacemit/ccu_pll.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/spacemit/ccu_pll.c b/drivers/clk/spacemit/ccu_pll.c
index 4427dcfbbb97..45f540073a65 100644
--- a/drivers/clk/spacemit/ccu_pll.c
+++ b/drivers/clk/spacemit/ccu_pll.c
@@ -122,7 +122,7 @@ static unsigned long ccu_pll_recalc_rate(struct clk_hw *hw,
WARN_ON_ONCE(!entry);
- return entry ? entry->rate : -EINVAL;
+ return entry ? entry->rate : 0;
}
static long ccu_pll_round_rate(struct clk_hw *hw, unsigned long rate,
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] clk: spacemit: ccu_pll: fix error return value in recalc_rate callback
2025-07-23 5:29 [PATCH v2] clk: spacemit: ccu_pll: fix error return value in recalc_rate callback Akhilesh Patil
@ 2025-07-25 2:36 ` Stephen Boyd
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Boyd @ 2025-07-25 2:36 UTC (permalink / raw)
To: akhilesh, alex, aou, conor+dt, dlan, elder, heylenay, heylenay,
inochiama, krzk+dt, mturquette, palmer, paul.walmsley, robh
Cc: linux-clk, linux-riscv, spacemit, linux-kernel, unicornxdotw,
jszhang, zhangmeng.kevin, akhileshpatilvnit, skhan
Quoting Akhilesh Patil (2025-07-22 22:29:56)
> Return 0 instead of -EINVAL if function ccu_pll_recalc_rate() fails to
> get correct rate entry. Follow .recalc_rate callback documentation
> as mentioned in include/linux/clk-provider.h for error return value.
>
> Signed-off-by: Akhilesh Patil <akhilesh@ee.iitb.ac.in>
> Fixes: 1b72c59db0add ("clk: spacemit: Add clock support for SpacemiT K1 SoC")
> Reviewed-by: Haylen Chu <heylenay@4d2.org>
> Reviewed-by: Alex Elder <elder@riscstar.com>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-07-25 2:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-23 5:29 [PATCH v2] clk: spacemit: ccu_pll: fix error return value in recalc_rate callback Akhilesh Patil
2025-07-25 2:36 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).