From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFC3B211F for ; Thu, 24 Jul 2025 00:16:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753316202; cv=none; b=j5T7sxOlvUg/rrxqZxw/VSEXhPAbOz9uGOB0ZNuCLfbhLtI34AGsC4f5boIt61FnF6GiWH8ULBvvrHWXbrpBED+yIRFkjkKNrPW7QIzrSCxXVzH1aMrAfKK3aSJ4FDq5eGOU47TJH3+QL9acOKc6R02DH49Os2KwJZ4zYQGZ+Vc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753316202; c=relaxed/simple; bh=pTqHQJPkx65su/NuAJ3No9eSQcZxl1N1hB4cgR2bU/E=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=lwgxzKTMZ6i06LL6/fXrsZ/9jhGRMB5A08nA9Y2ZFCE+VfQpP5Ep9++07gq2VnZ0SIwvCMBAW2Ql4n5McaldEs2YvTt6G3Iq/8utlnX5PFJrs9+p8BqFNtONhYV28Gwj+UFGHJ/ToE9+rllFM+0I91+sNhCEJ92GwM02mI1AunY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=NbdPVhoh; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="NbdPVhoh" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-3121cffd7e8so363764a91.0 for ; Wed, 23 Jul 2025 17:16:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1753316200; x=1753921000; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=RPZ6P7qny163Me6EPudgKXJwV0FhWmeseWBHotelotw=; b=NbdPVhohvZZDn7cBTTvNgo+/lnWLy52I5gTmj1TuCwn/YyMtOwnp1L//eBiouGBwR3 NTHXSqTFdtWxoV1wMZm62mkr3aVRlIyHWaEap8yz3MCTwa89dtkjcQpbgSyAorUf0Fzz QaxkPj7L/b7Ub2j1jeqMCYYuCOUGqO/DssqiEXkE3hRgMGJw04eaE16VfmkGgtwn6TKa fMSioBLWAnJFr2jvglxAS2x5O2+q15hwKgyEjhFutaqUjYIghX7k6pkKG6n7DMkZiFh+ olfYQbVrtoYZZxxbo4hewvwTNDEm62Dj1XUjsD+iZ7Nb+eeuRRvQSihiWZZXgQnsoF7O Ei0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753316200; x=1753921000; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RPZ6P7qny163Me6EPudgKXJwV0FhWmeseWBHotelotw=; b=ZGQrgRqk11JIoPyxVNHWpit5sxtLAosN2fRqEVs2mdZkSnl32paifhe/nqaAffPvgu waK2EXq6oFDNwylQPmwNAIj2ddObRnpXaryWD2IV5ayY6owVdv5734ySfndEtvHtFnfw vXKL2J8hAc+yIKyWRtsa9cQsdeEg+MTX0TES915IG22md4IRLcj3anQGtJ5QMCXRo4Co ML8GEKQcR8vp3WCYbAoogmW4mitEywxixfKsKqCRPQbwzkDanXfFk3uqxOVTrYaDA6sh xMdSvrJwkZyEcd4taYFCWlItXiQEkVQzFt/oLCnQ6ckemwnWlaGuA1P9M49axbY3xO6L IEnw== X-Forwarded-Encrypted: i=1; AJvYcCURXkcUZchoDEEkh7v4naXYE0EqWrq1seU53SLwt9MWNXwL9pSqbmS0YckDWIBtMKAz7vJaf5HQBSa3nYk=@vger.kernel.org X-Gm-Message-State: AOJu0YwL2hhGi3Av+BNwrQ+zXPgQN9/gBycCMjRuuI6XJIZep8u1/3lL EI0wGnpAygKXeZyLwyezX5lvkEBedAE3TrXLaMbEQfyxW1JoF87p7qiROtc9D4on9J7+MhOigD4 pceWsVg== X-Google-Smtp-Source: AGHT+IG46sVTGrQfC+1ZcgLyXUFOMidiHD1ofE0XoALXwfSqQrVszox75E3QvJ62kfppObrtzgyM9Vs3LX8= X-Received: from pjtd18.prod.google.com ([2002:a17:90b:52:b0:2fe:800f:23a]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:240b:b0:31e:60ac:bf65 with SMTP id 98e67ed59e1d1-31e60acc86emr1085678a91.27.1753316200082; Wed, 23 Jul 2025 17:16:40 -0700 (PDT) Date: Wed, 23 Jul 2025 17:16:38 -0700 In-Reply-To: <20250714103440.394654786@infradead.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250714102011.758008629@infradead.org> <20250714103440.394654786@infradead.org> Message-ID: Subject: Re: [PATCH v3 07/16] x86/kvm/emulate: Introduce EM_ASM_1SRC2 From: Sean Christopherson To: Peter Zijlstra Cc: x86@kernel.org, kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, pbonzini@redhat.com, ardb@kernel.org, kees@kernel.org, Arnd Bergmann , gregkh@linuxfoundation.org, jpoimboe@kernel.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-efi@vger.kernel.org, samitolvanen@google.com, ojeda@kernel.org Content-Type: text/plain; charset="us-ascii" For all of the KVM patches, please use KVM: x86: "x86/kvm" is used for guest-side code, and while I hope no one will conflate this with guest code, the consistency is helpful. On Mon, Jul 14, 2025, Peter Zijlstra wrote: > Replace the FASTOP1SRC2*() instructions. > > Signed-off-by: Peter Zijlstra (Intel) > --- > arch/x86/kvm/emulate.c | 34 ++++++++++++++++++++++++++-------- > 1 file changed, 26 insertions(+), 8 deletions(-) > > --- a/arch/x86/kvm/emulate.c > +++ b/arch/x86/kvm/emulate.c > @@ -317,6 +317,24 @@ static int em_##op(struct x86_emulate_ct > ON64(case 8: __EM_ASM_1(op##q, rax); break;) \ > EM_ASM_END > > +/* 1-operand, using "c" (src2) */ > +#define EM_ASM_1SRC2(op, name) \ > + EM_ASM_START(name) \ > + case 1: __EM_ASM_1(op##b, cl); break; \ > + case 2: __EM_ASM_1(op##w, cx); break; \ > + case 4: __EM_ASM_1(op##l, ecx); break; \ > + ON64(case 8: __EM_ASM_1(op##q, rcx); break;) \ > + EM_ASM_END > + > +/* 1-operand, using "c" (src2) with exception */ > +#define EM_ASM_1SRC2EX(op, name) \ > + EM_ASM_START(name) \ > + case 1: __EM_ASM_1_EX(op##b, cl); break; \ > + case 2: __EM_ASM_1_EX(op##w, cx); break; \ > + case 4: __EM_ASM_1_EX(op##l, ecx); break; \ > + ON64(case 8: __EM_ASM_1(op##q, rcx); break;) \ This needs to be __EM_ASM_1_EX(). Luckily, KVM-Unit-Tests actually has testcase for divq (somewhere in the morass of testcases). I also now have an extension to the fastops selftest to explicitly test all four flavors of div-by-zero; I'll get it posted tomorrow. (also, don't also me how long it took me to spot the copy+paste typo; I was full on debugging the exception fixup code before I realized my local diff looked "odd", *sigh*)