From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DEE52BD04 for ; Mon, 28 Jul 2025 14:14:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753712046; cv=none; b=d3Hjyg/4qej7B9x6G8E8ip5gv8bhu8nqC18O1GPHuagU8duWPoBnzly3//zUREZXjeutcOtcYgiTU3pRO2flUvEuLNYAFxEj2A5PPBwTu31FcBue4gSneAC69eP06P3A2qjT+s8zxBWDIe4Zi298FilzGbutfUTMn9mEu89iMew= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753712046; c=relaxed/simple; bh=g45KzbwgBA7e0spemcISRrjUGP7tGUQ7fGO81mfXqk0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SM1iscXEa1yRk6Lz7FOexrPANGjN+3Oy5HReMWbG6P02SVSw56TTNnbMsfilXuIHCXsmAKzHhRKe4MS6hNYrfq2qlO8ImyIOB2bCZdW7ajN3wB8dtc/MmdVFJZ9bw6i4dU0yYzq3UdqhkSx3VfEC/RuIgWJX8mPtqLox6P7TAx0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Cchhokgs; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Cchhokgs" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-7494999de5cso3047047b3a.3 for ; Mon, 28 Jul 2025 07:14:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1753712045; x=1754316845; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=VkRksZeZRdJUhfD+fysrVUZxN07ubnU6SAGQQ5LsnD4=; b=Cchhokgsch93syKkeSWdM8oLlX8eQAJ8c+DhP0MaKIZX9Zy0zIQpGyWhROHwoob40q rCwDuQG2VSB1/8p/Lhn/xYPKQ4UCMHKUleTfIdmmJsbLsPX28DR54CVqwINT2OjYVfp/ w8THvE4A8qYArT4nA0DCs4Xj4m84odVpy+MMLsbHXrRyF88ExeuvaxZn34efqpTaUD7H D3z/s7Imi8AHCvgJTECJi0QQY8cEaNXhoa2kjNgtuj6bgrAaFQ05/J60l3qpxHs/evLO DMS5tRJrLGHCw0GM6Sf2W5esB3TlVhhxT9WGn7EIxPIjkzwpLcjzMBjP3ikj2GQ/FP1A LgjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753712045; x=1754316845; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VkRksZeZRdJUhfD+fysrVUZxN07ubnU6SAGQQ5LsnD4=; b=R0mP6noGqeGPat/EjMhk06lH4siZ42eOTGLGfpI3mWeUDQpHJCvaG554UZX2zg18PO BgTY5tcbM3gvoNhnviEaQ9SBw5j1ncFvX/7rOH3TrA1rwuWZv+P4JO7sauQ19HTK7eKe CV6ojuLf5ut5xXU+oLnWf2n9eoe8JNXMPj5Mkhpn4HUAzL4T/3xXrLdtnSmWfRpHyUOx Q50rxK+IF8xbRIh6Ypqok518C9Q8K2Pd7lMAH1MVh5yV5sM7ANCFHqNefg1qb1fXSkov tzZ4GpGQquULfm8xvRtT3pihNEqOZHjL2GgWbg6oRFjw5pFLN0f6tO/9kcjyfrnCpqK1 T3DA== X-Forwarded-Encrypted: i=1; AJvYcCVZuDNpXJ8Rl+ZVWmvhPo2mB5f51+deYyQFx9Pfgnn2/CW1IriP/UQEwiQfcmJEZkl9gbPF6IChJ1wPtRs=@vger.kernel.org X-Gm-Message-State: AOJu0YyCsEQ2zGyi5i2TdRTqwRMkJI2Fw2fItAnU/MuaOIwoTlwWMxuc d8aInHoEL3fU0qeVnDDSbpjs/dkmw7E4d3oTBMZyhvnE7DsjEVHaNu8Y0Fbflru7mFA= X-Gm-Gg: ASbGncsEOl1E2Y4ZTj4E0zaq0rgynMAD1H7tDU9AEzgQJOwjOaLLZMcNxObtdo0VZ6j bKJj62gd40RWkZzOup4dhGygPdFm1EckYJvyobGfg4cONWF+mms8Wyrcax5Q7m7lQxA1Yykh0tn NyvZp9yLumchjU046jeUYNuitG1q0vvi1EbMoqeDDf+rO9p/NGueh/Eyw3Vq2VwxV6ioTP9Jtxt 1WTBJ1i06HYDd54myGYQS7VAg6EBfxvnpNcPjB8009AsYe5abfsL3a/VyciP3WbLDqt9elBDK2W 6tXO37AFRsnq2E0Uud4asvZoH+Y/G1Ov9JGMtE0lJepsp7vTYPS/WQFPDfccYUjqdZG+tqpXDbe R7CnUiroZcue69DZedyC52eqr+CorEL4Dr0S/ X-Google-Smtp-Source: AGHT+IEzYHk+WznmPpX9Fulm4uS2KRvmZT0lrK8OW5a60R5q4nnqwgfy/r5C+L542XQYKAZbclCwBg== X-Received: by 2002:a05:6a21:3d95:b0:23d:ac50:3342 with SMTP id adf61e73a8af0-23dac5033femr345980637.38.1753712044666; Mon, 28 Jul 2025 07:14:04 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:82ce:5506:d365:5bcb]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-76419d84234sm5604059b3a.57.2025.07.28.07.14.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Jul 2025 07:14:03 -0700 (PDT) Date: Mon, 28 Jul 2025 08:14:01 -0600 From: Mathieu Poirier To: Daniel Baluta Cc: Shengjiu Wang , andersson@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] remoteproc: imx_dsp_rproc: Add support of recovery and coredump process Message-ID: References: <20250722075225.544319-1-shengjiu.wang@nxp.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Jul 28, 2025 at 01:39:38PM +0300, Daniel Baluta wrote: > On Tue, Jul 22, 2025 at 11:16 AM Shengjiu Wang wrote: > > > > When enabled FW recovery, but is broken because software reset is missed > > in this recovery flow. So move software reset from > > imx_dsp_runtime_resume() to .load() and clear memory before loading > > firmware to make recovery work. > > > > Add call rproc_coredump_set_elf_info() to initialize the elf info for > > coredump, otherwise coredump will report error "ELF class is not set". > > > > Fixes: ec0e5549f358 ("remoteproc: imx_dsp_rproc: Add remoteproc driver for DSP on i.MX") > > Signed-off-by: Shengjiu Wang > > Changes looks good to me: > > Reviewed-by: Daniel Baluta > > I've tested it with Zephyr synchronization samples inducing a crash > via debugfs interface. App > can recover correctly. Very good - I will merge this around 6.17-rc2 when I get back from vacation. Mathieu