[PATCH] kho: fix kho_test_restore section mismatch warning

[PATCH] kho: fix kho_test_restore section mismatch warning

[Arnd Bergmann]

From: Arnd Bergmann <arnd@arndb.de>

kho_test_restore_data() is not always inlined, and that configuration
causes a link warning:

WARNING: modpost: vmlinux: section mismatch in reference: kho_test_restore+0xd2 (section: .text.unlikely) -> kho_test_restore_data.isra.0 (section: .init.text)
ERROR: modpost: Section mismatches detected.

Mark it __init as well to be consistent with the rest of the call chain.

Fixes: c2d288f7ab13 ("kho: add test for kexec handover")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 lib/test_kho.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/test_kho.c b/lib/test_kho.c
index f5fe39c7c2b1..aeeb693d0251 100644
--- a/lib/test_kho.c
+++ b/lib/test_kho.c
@@ -239,7 +239,7 @@ static int __init kho_test_restore_data(const void *fdt, int node)
 	return 0;
 }
 
-static int kho_test_restore(phys_addr_t fdt_phys)
+static int __init kho_test_restore(phys_addr_t fdt_phys)
 {
 	void *fdt = phys_to_virt(fdt_phys);
 	const unsigned int *magic;
-- 
2.39.5

Re: [PATCH] kho: fix kho_test_restore section mismatch warning

[Mike Rapoport]

Hi Arnd,

On Thu, Jul 31, 2025 at 10:00:00AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> kho_test_restore_data() is not always inlined, and that configuration
> causes a link warning:
> 
> WARNING: modpost: vmlinux: section mismatch in reference: kho_test_restore+0xd2 (section: .text.unlikely) -> kho_test_restore_data.isra.0 (section: .init.text)
> ERROR: modpost: Section mismatches detected.
> 
> Mark it __init as well to be consistent with the rest of the call chain.

I've already sent a fix:

https://lore.kernel.org/all/aIiRC8fXiOXKbPM_@kernel.org/

and Andrew picked it up.
 
> Fixes: c2d288f7ab13 ("kho: add test for kexec handover")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  lib/test_kho.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/test_kho.c b/lib/test_kho.c
> index f5fe39c7c2b1..aeeb693d0251 100644
> --- a/lib/test_kho.c
> +++ b/lib/test_kho.c
> @@ -239,7 +239,7 @@ static int __init kho_test_restore_data(const void *fdt, int node)
>  	return 0;
>  }
>  
> -static int kho_test_restore(phys_addr_t fdt_phys)
> +static int __init kho_test_restore(phys_addr_t fdt_phys)
>  {
>  	void *fdt = phys_to_virt(fdt_phys);
>  	const unsigned int *magic;
> -- 
> 2.39.5
> 

-- 
Sincerely yours,
Mike.