Re: [PATCH] drm/vkms: Assert if vkms_config_create_*() fails

["José Expósito" <jose.exposito89@gmail.com>]

Hi everyone,

On Tue, Aug 12, 2025 at 11:39:53AM +0300, Dan Carpenter wrote:
> On Mon, Aug 11, 2025 at 07:21:18PM +0200, Louis Chauvet wrote:
> > 
> > 
> > Le 11/08/2025 à 12:15, José Expósito a écrit :
> > > Check that the value returned by the vkms_config_create_*() functions is
> > > valid. Otherwise, assert and finish the KUnit test.
> > > 
> > > Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> > > Closes: https://lore.kernel.org/dri-devel/aJTL6IFEBaI8gqtH@stanley.mountain/
> > > Signed-off-by: José Expósito <jose.exposito89@gmail.com>
> > 
> > Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>
> > 
> > I am not sure on how to use smach, I don't have any warning at all for the
> > whole kernel, so I will wait for Dan Carpenter review before applying.
> > 
> 
> Looks good.  Thanks!
> 
> Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>

Thanks to the both of you for your reviews :D

As a side note, I also couldn't make Smatch to report these warnings,
so thanks a lot for verifying that they are fixed.

Jose

> > Side question: should we use __must_check in this case to warn at compile
> > time?
> 
> We wouldn't normally...  It turns out the existing code was already
> checking for errors so this is really just a "silence the checker"
> patch.
> 
> regards,
> dan carpenter
>