From: Lukas Wunner <lukas@wunner.de>
To: Niklas Schnelle <schnelle@linux.ibm.com>
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
"Mahesh J Salgaonkar" <mahesh@linux.ibm.com>,
"Linas Vepstas" <linasvepstas@gmail.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Gerald Schaefer" <gerald.schaefer@linux.ibm.com>,
"Heiko Carstens" <hca@linux.ibm.com>,
"Vasily Gorbik" <gor@linux.ibm.com>,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Sven Schnelle" <svens@linux.ibm.com>,
"Peter Oberparleiter" <oberpar@linux.ibm.com>,
"Matthew Rosato" <mjrosato@linux.ibm.com>,
"Oliver O'Halloran" <oohall@gmail.com>,
"Sinan Kaya" <okaya@kernel.org>,
linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
"Keith Busch" <kbusch@kernel.org>
Subject: Re: [PATCH v4 2/3] powerpc/eeh: Use result of error_detected() in uevent
Date: Thu, 7 Aug 2025 13:34:43 +0200 [thread overview]
Message-ID: <aJSPU6bF-DRNN1ZT@wunner.de> (raw)
In-Reply-To: <20250807-add_err_uevents-v4-2-c624bfd8638d@linux.ibm.com>
On Thu, Aug 07, 2025 at 12:15:32PM +0200, Niklas Schnelle wrote:
> With pci_uevent_ers() handling PCI_ERS_RESULT_NEED_RESET the result of
> error_detected() can be used in pci_uevent_ers() even if drivers request
> a reset. This aligns EEH's behavior with both AER.
I guess the sentence is supposed to end with "and s390"?
I would have recounted the history a bit, e.g.:
Ever since uevent support was added for AER and EEH with commit
856e1eb9bdd4 ("PCI/AER: Add uevents in AER and EEH error/resume"), it
reported PCI_ERS_RESULT_NONE as the result of ->error_detected() to
user space.
Commit 7b42d97e99d3 ("PCI/ERR: Always report current recovery status for
udev") subsequently amended AER to report the actual return value of
->error_detected().
Make the same change to EEH to align it with AER (and s390 error
recovery).
> Suggested-by: Lukas Wunner <lukas@wunner.de>
> Link: https://lore.kernel.org/linux-pci/aIp6LiKJor9KLVpv@wunner.de/
> Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
Reviewed-by: Lukas Wunner <lukas@wunner.de>
next prev parent reply other threads:[~2025-08-07 11:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-07 10:15 [PATCH v4 0/3] PCI/ERR: s390/pci: Use pci_uevent_ers() in PCI recovery Niklas Schnelle
2025-08-07 10:15 ` [PATCH v4 1/3] PCI/AER: Fix missing uevent on recovery when a reset is requested Niklas Schnelle
2025-08-07 10:15 ` [PATCH v4 2/3] powerpc/eeh: Use result of error_detected() in uevent Niklas Schnelle
2025-08-07 11:34 ` Lukas Wunner [this message]
2025-08-07 11:49 ` Niklas Schnelle
2025-08-07 10:15 ` [PATCH v4 3/3] PCI/ERR: s390/pci: Use pci_uevent_ers() in PCI recovery Niklas Schnelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJSPU6bF-DRNN1ZT@wunner.de \
--to=lukas@wunner.de \
--cc=agordeev@linux.ibm.com \
--cc=bhelgaas@google.com \
--cc=borntraeger@linux.ibm.com \
--cc=gerald.schaefer@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=kbusch@kernel.org \
--cc=linasvepstas@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.ibm.com \
--cc=mani@kernel.org \
--cc=mjrosato@linux.ibm.com \
--cc=oberpar@linux.ibm.com \
--cc=okaya@kernel.org \
--cc=oohall@gmail.com \
--cc=schnelle@linux.ibm.com \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).