* [PATCH] dt-bindings: ipmi: aspeed,ast2400-kcs-bmc: Add missing "clocks" property
@ 2025-08-07 13:28 Rob Herring (Arm)
2025-08-08 1:47 ` Andrew Jeffery
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring (Arm) @ 2025-08-07 13:28 UTC (permalink / raw)
To: Corey Minyard, Krzysztof Kozlowski, Conor Dooley, Joel Stanley,
Andrew Jeffery
Cc: Andrew Jeffery, openipmi-developer, devicetree, linux-arm-kernel,
linux-aspeed, linux-kernel
The ASpeed kcs-bmc nodes have a "clocks" property which isn't
documented. It looks like all the LPC child devices have the same clock
source and some of the drivers manage their clock. Perhaps it is the
parent device that should have the clock, but it's too late for that.
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
.../devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml b/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml
index 129e32c4c774..610c79863208 100644
--- a/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml
+++ b/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml
@@ -40,6 +40,9 @@ properties:
- description: ODR register
- description: STR register
+ clocks:
+ maxItems: 1
+
aspeed,lpc-io-reg:
$ref: /schemas/types.yaml#/definitions/uint32-array
minItems: 1
--
2.47.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: ipmi: aspeed,ast2400-kcs-bmc: Add missing "clocks" property
2025-08-07 13:28 [PATCH] dt-bindings: ipmi: aspeed,ast2400-kcs-bmc: Add missing "clocks" property Rob Herring (Arm)
@ 2025-08-08 1:47 ` Andrew Jeffery
2025-08-08 14:48 ` Corey Minyard
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Jeffery @ 2025-08-08 1:47 UTC (permalink / raw)
To: Rob Herring (Arm), Corey Minyard, Krzysztof Kozlowski,
Conor Dooley, Joel Stanley
Cc: Andrew Jeffery, openipmi-developer, devicetree, linux-arm-kernel,
linux-aspeed, linux-kernel
On Thu, 2025-08-07 at 08:28 -0500, Rob Herring (Arm) wrote:
> The ASpeed kcs-bmc nodes have a "clocks" property which isn't
> documented. It looks like all the LPC child devices have the same clock
> source and some of the drivers manage their clock. Perhaps it is the
> parent device that should have the clock, but it's too late for that.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Thanks Rob.
Acked-by: Andrew Jeffery <andrew@codeconstruct.com.au>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: ipmi: aspeed,ast2400-kcs-bmc: Add missing "clocks" property
2025-08-08 1:47 ` Andrew Jeffery
@ 2025-08-08 14:48 ` Corey Minyard
0 siblings, 0 replies; 3+ messages in thread
From: Corey Minyard @ 2025-08-08 14:48 UTC (permalink / raw)
To: Andrew Jeffery
Cc: Rob Herring (Arm), Krzysztof Kozlowski, Conor Dooley,
Joel Stanley, Andrew Jeffery, openipmi-developer, devicetree,
linux-arm-kernel, linux-aspeed, linux-kernel
On Fri, Aug 08, 2025 at 11:17:29AM +0930, Andrew Jeffery wrote:
> On Thu, 2025-08-07 at 08:28 -0500, Rob Herring (Arm) wrote:
> > The ASpeed kcs-bmc nodes have a "clocks" property which isn't
> > documented. It looks like all the LPC child devices have the same clock
> > source and some of the drivers manage their clock. Perhaps it is the
> > parent device that should have the clock, but it's too late for that.
> >
> > Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
>
> Thanks Rob.
>
> Acked-by: Andrew Jeffery <andrew@codeconstruct.com.au>
Queued for 4.18, I'll add it to the next tree when 4.17-rc1 releases.
Thanks,
-corey
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-08-08 14:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-07 13:28 [PATCH] dt-bindings: ipmi: aspeed,ast2400-kcs-bmc: Add missing "clocks" property Rob Herring (Arm)
2025-08-08 1:47 ` Andrew Jeffery
2025-08-08 14:48 ` Corey Minyard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).