From: Dan Carpenter <dan.carpenter@linaro.org>
To: Yao-Wen Chang <changyaowen19980629@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/11] staging: rtl8723bs: Rename camelCase variables to snake_case
Date: Mon, 11 Aug 2025 10:24:57 +0300 [thread overview]
Message-ID: <aJmaycoFLHELApC0@stanley.mountain> (raw)
In-Reply-To: <20250811062132.102525-1-changyaowen19980629@gmail.com>
On Mon, Aug 11, 2025 at 02:21:24PM +0800, Yao-Wen Chang wrote:
> @@ -804,14 +804,14 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf, int len)
> {
> int ret = _SUCCESS;
> u8 *p;
> - u8 *pHT_caps_ie = NULL;
> - u8 *pHT_info_ie = NULL;
> + u8 *p_HT_caps_ie = NULL;
> + u8 *p_HT_info_ie = NULL;
The letter "p_" stands for pointer here. We hate that kind of naming
scheme.
regards,
dan carpenter
prev parent reply other threads:[~2025-08-11 7:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 6:21 [PATCH 01/11] staging: rtl8723bs: Rename camelCase variables to snake_case Yao-Wen Chang
2025-08-11 6:21 ` [PATCH 02/11] staging: rtl8723bs: Reformat code to respect 100-column line limit Yao-Wen Chang
2025-08-11 7:30 ` Dan Carpenter
2025-08-11 6:21 ` [PATCH 03/11] staging: rtl8723bs: Remove empty line Yao-Wen Chang
2025-08-11 6:21 ` [PATCH 04/11] staging: rtl8723bs: Fix the line end with ( issue Yao-Wen Chang
2025-08-11 6:21 ` [PATCH 05/11] staging: rtl8723bs: Rmove unnecessary parentheses around the statement Yao-Wen Chang
2025-08-11 6:21 ` [PATCH 06/11] staging: rtl8723bs: Remove redundant comparison to true and false Yao-Wen Chang
2025-08-11 6:21 ` [PATCH 07/11] staging: rtl8723bs: Add spaces around binary operators Yao-Wen Chang
2025-08-11 6:21 ` [PATCH 08/11] staging: rtl8723bs: Enforce alignment match open parenthesis Yao-Wen Chang
2025-08-11 6:21 ` [PATCH 09/11] staging: rtl8723bs: Rename camelCaseVar to snake_case_var Yao-Wen Chang
2025-08-11 7:24 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJmaycoFLHELApC0@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=changyaowen19980629@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).