From: Dan Carpenter <dan.carpenter@linaro.org>
To: Scott Guo <scott_gzh@163.com>
Cc: Markus Elfring <Markus.Elfring@web.de>,
Scott Guo <scottzhguo@tencent.com>,
Phillip Lougher <phillip@squashfs.org.uk>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] squashfs: Avoid mem leak in squashfs_fill_super
Date: Tue, 12 Aug 2025 11:18:38 +0300 [thread overview]
Message-ID: <aJr43n1np2nB8bht@stanley.mountain> (raw)
In-Reply-To: <461ae944-5fb9-4860-81c1-1ac48c3d888f@163.com>
On Tue, Aug 12, 2025 at 10:11:21AM +0800, Scott Guo wrote:
> >
> > By the way:
> > I propose to refine the goto chain by using additional labels like “e_inval” and “e_nomem”
> > so that another bit of exception handling code can be shared at the end
> > of this function implementation.
> > https://elixir.bootlin.com/linux/v6.16/source/fs/squashfs/super.c#L434-L466
> Will have a look into that, but maybe fix the current issue first.>
Please, don't introduce more of those e_inval, e_nomem labels.
regards,
dan carpenter
next prev parent reply other threads:[~2025-08-12 8:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 6:19 [PATCH] squashfs: Avoid mem leak in squashfs_fill_super scott_gzh
2025-08-11 7:02 ` Markus Elfring
2025-08-12 2:11 ` Scott Guo
2025-08-12 8:18 ` Dan Carpenter [this message]
2025-08-12 8:38 ` Markus Elfring
2025-08-12 9:20 ` Dan Carpenter
2025-08-11 22:35 ` [PATCH] " Phillip Lougher
2025-08-12 2:11 ` Scott Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJr43n1np2nB8bht@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=Markus.Elfring@web.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phillip@squashfs.org.uk \
--cc=scott_gzh@163.com \
--cc=scottzhguo@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox