linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dominique Martinet <asmadeus@codewreck.org>
To: Harry Yoo <harry.yoo@oracle.com>
Cc: syzbot <syzbot+3f9768ec54c86997ddfb@syzkaller.appspotmail.com>,
	akpm@linux-foundation.org, apopple@nvidia.com, byungchul@sk.com,
	david@redhat.com, gourry@gourry.net, joshua.hahnjy@gmail.com,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	matthew.brost@intel.com, rakie.kim@sk.com,
	Eric Van Hensbergen <ericvh@kernel.org>,
	Latchesar Ionkov <lucho@ionkov.net>,
	Christian Schoenebeck <linux_oss@crudebyte.com>,
	syzkaller-bugs@googlegroups.com, ying.huang@linux.alibaba.com,
	ziy@nvidia.com
Subject: Re: [syzbot] [mm?] WARNING in alloc_frozen_pages_noprof
Date: Wed, 13 Aug 2025 13:49:02 +0900	[thread overview]
Message-ID: <aJwZPq0b2rckG-ap@codewreck.org> (raw)
In-Reply-To: <aJvc5m8Ocm3S_Xkc@hyeyoo>

Harry Yoo wrote on Wed, Aug 13, 2025 at 09:31:34AM +0900:
> The warning is:
> 
> 	/*
> 	 * There are several places where we assume that the order value is sane
> 	 * so bail out early if the request is out of bound.
> 	 */
> 	if (WARN_ON_ONCE_GFP(order > MAX_PAGE_ORDER, gfp))
> 		return NULL;
> 
> There's not much the buddy allocator can do when a user requests
> order > MAX_PAGE_ORDER allocations.
> 
> >  alloc_pages_mpol+0x1e4/0x460 mm/mempolicy.c:2416
> >  alloc_frozen_pages_noprof+0xe0/0x210 mm/mempolicy.c:2487
> >  ___kmalloc_large_node+0xac/0x154 mm/slub.c:4306
> >  __kmalloc_large_node_noprof+0x2c/0x8c mm/slub.c:4337
> >  __do_kmalloc_node mm/slub.c:4353 [inline]
> >  __kmalloc_noprof+0x3bc/0x4c8 mm/slub.c:4377
> >  kmalloc_noprof include/linux/slab.h:909 [inline]
> >  kzalloc_noprof include/linux/slab.h:1039 [inline]
> >  v9fs_fid_get_acl+0x64/0x114 fs/9p/acl.c:32
> 
> So... 9p FS shouldn't really request that?
> 
> Cc'ing 9p FS folks.

Thanks for the Cc.

So, this comes up once in a while, everytime we discuss limiting the
xattr size, then someone says we should do something else or I'm using
the wrong define or I don't remember and then when I ask what we should
do never reply again.

See [1] or [2] for the last two time this happened.
[1] https://lore.kernel.org/all/20240304-xattr_maxsize-v1-1-322357ec6bdf@codewreck.org/T/#u
[2] https://lore.kernel.org/lkml/20240202121319.21743-1-pchelkin@ispras.ru/

I'll be happy to take any patch you send (or one of the older patches if
you tell me which is "correct"), I don't care anymore.
-- 
Dominique

  reply	other threads:[~2025-08-13  4:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-12 21:56 [syzbot] [mm?] WARNING in alloc_frozen_pages_noprof syzbot
2025-08-13  0:31 ` Harry Yoo
2025-08-13  4:49   ` Dominique Martinet [this message]
2025-08-15 13:17     ` Christian Schoenebeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aJwZPq0b2rckG-ap@codewreck.org \
    --to=asmadeus@codewreck.org \
    --cc=akpm@linux-foundation.org \
    --cc=apopple@nvidia.com \
    --cc=byungchul@sk.com \
    --cc=david@redhat.com \
    --cc=ericvh@kernel.org \
    --cc=gourry@gourry.net \
    --cc=harry.yoo@oracle.com \
    --cc=joshua.hahnjy@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux_oss@crudebyte.com \
    --cc=lucho@ionkov.net \
    --cc=matthew.brost@intel.com \
    --cc=rakie.kim@sk.com \
    --cc=syzbot+3f9768ec54c86997ddfb@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=ying.huang@linux.alibaba.com \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).