From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f179.google.com (mail-il1-f179.google.com [209.85.166.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B71A2C0F90 for ; Wed, 13 Aug 2025 20:39:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755117593; cv=none; b=B4cUeTP6yuaEb79xEcEQWjuwJKwjIk17Qx0yhD301VYnxFgQq4fuHuMPiPpBbRFCpAF1X58pHcYvzG0jXcMeaBiQFZErJgkVf7vxEA4T91p3X3yYi6FdOvKuENZ6AqD4WBoKQvJoZX5mwbXgzR8hgm5tt7Bi848AWwYqp1O4OXA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755117593; c=relaxed/simple; bh=AXffZ9dyioE6nOqSGA3Jy2oI5Z20yBGFwOs8nynpzPA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aWoRwWON7goPc4K97nNdBmT7PX3pFagsaruv7uC8QatvS1xXhEP9TB3JCagPwmlkX7rn1ic8vBeWYMhuHlzC/JUYd/aVDOJZeJOugFhTiQJeTIcOSb6OVQul/ehiWcFIt4Rg53cjp6MzVZHyI0vSGb8Qxbso1TiwVtfykT7L620= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cloudflare.com; spf=pass smtp.mailfrom=cloudflare.com; dkim=pass (2048-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b=dR34cAxp; arc=none smtp.client-ip=209.85.166.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b="dR34cAxp" Received: by mail-il1-f179.google.com with SMTP id e9e14a558f8ab-3e56fc0f337so2469245ab.1 for ; Wed, 13 Aug 2025 13:39:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google09082023; t=1755117591; x=1755722391; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=lP0QH6bmUQ+2Acs8+Imh9XZZLiBHsh0NRGzPgFU6eoo=; b=dR34cAxpfjkdqNi00u1SayjSu6D3QJVGRvDkez4iGJyTdpwNsfSnpEvPYwR/bkkGH8 bmaF2H3smnrV8IF5gVz8ckv4kqXrNfgSJAVQw/q/guhxrXYFgwM5a4DR34ipn+nlGB4L fSsXNnZhO1iYH8WP/t03Y1/SChz5tQH+rstUERX7bgWuk1VvEDeg+eOPHOQs2zg/0R3u Ze/ym8Jom2p8Cd/QNAMwQwRaLBYcF0lmN0LUhoaxNxQF9iyQz4sRIiqWEggNREraBZEF oR6q74QpAnM+PA4dkKcbTHabvs3ebv9mROBP7wVv1LoXmKIIjMcReCP0tL5pBGy5RNG0 QGBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755117591; x=1755722391; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lP0QH6bmUQ+2Acs8+Imh9XZZLiBHsh0NRGzPgFU6eoo=; b=ud2a/jLlxVqfEb2AiMd0P1I2VWdf50OWfJvCN5hWqSrYPj7AEkrAIcVtbPcXngqE4u v+oJpRDgE7fYNzh8sH7JpBjIl+p8kDqwmTT0VTY25djPKcvXA5KIGMY35+K/nDjCdsEG XQseVxiRI1IGI/pLsqMZnksaJ1c9GdH2Fr20s45aJFoJ8j62tBB8A/AD/m/rEKRY9Tgg FFuofn+kj42Wly20eggts9NSqMa+CooEduCA5pHNJm6Tq7qUppViUVcOnQhX3c+XTR86 znNu5b136Ho8EVxtIJ7hiYtLPX5sc1Qs7odBm7MH3pHrTjPpiHLZ9Tmob9Jc8MMX+V3C xxpg== X-Forwarded-Encrypted: i=1; AJvYcCVg68gYD5g9kV8JOjl04dtMcg2j3BuRcXdGkzFGbvxTUeI+fi8HZxgfllCXri3rpJd15KW34YrVSf3QkPs=@vger.kernel.org X-Gm-Message-State: AOJu0YzxX+XDc5SxJ79p12REArAcbWOw9fWpZ23vvmFL15SjeqjVRq+G N84bsHsCtR/SLOTv3Kzi+QZRAlxv+ISIqpupLQI4nwjyzUgcy43/kksI/CnPqXSJFkE= X-Gm-Gg: ASbGncu4iQPMH1EREImRAvwv9uL3QlYrYED8Xn2VzuWI4+K8dVtsL5kYKyhmaaS93Bi cRotT2FDIQcg6wRismcVhfjruRkM8uHrPO84FKPEhWO5B4wtD8XVA7KyJ5s5k4foOafmACl7PWZ 5sl965BKRNs0ZujHP+dcc+uN+0I/c0PbL/5j1FcEw7NlIg6ekSVa208lxlyOlPQS49fTxapYyo0 jCFH2ll8WasTCuplKSuwEy4osyqTFfTPa7nEtNdS71OO3XxKw2qyfKuLOsqlgYYlD4CUot1A8y5 NLr0pfH7Xbu0md7FQh+z41afZaAICbOF6rupiloa6IIsfBQAm6LC5ckud6ub2f5sdxneiR6M6VR Hy8U= X-Google-Smtp-Source: AGHT+IF33uU6G1tdISaoHujqKFCv7GAhmf5MtVqMPZeo70bmBvi9Ma2tNnrW3cr8EJyPXQvpDlIPHA== X-Received: by 2002:a05:6e02:b4f:b0:3de:e74:be13 with SMTP id e9e14a558f8ab-3e571530619mr5127105ab.0.1755117590530; Wed, 13 Aug 2025 13:39:50 -0700 (PDT) Received: from CMGLRV3 ([2a09:bac5:8255:1b37::2b6:1]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-50ae99cd268sm3918681173.22.2025.08.13.13.39.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Aug 2025 13:39:50 -0700 (PDT) Date: Wed, 13 Aug 2025 15:39:48 -0500 From: Frederick Lawler To: Paul Moore Cc: Eric Paris , audit@vger.kernel.org, kernel-team@cloudflare.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] audit: make ADUITSYSCALL optional again Message-ID: References: <20250808194034.3559323-1-fred@cloudflare.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Paul, On Wed, Aug 13, 2025 at 12:01:42PM -0400, Paul Moore wrote: > On Aug 8, 2025 Frederick Lawler wrote: > > > > Since the introduction of commit cb74ed278f80 ("audit: always enable > > syscall auditing when supported and audit is enabled"), eBPF > > technologies are being adopted to track syscalls for auditing purposes. > > Those technologies add an additional overhead ontop of AUDITSYSCALL. > > Additionally, AUDIT infrastructure has expanded to include INTEGRITY which > > offers some advantages over eBPF technologies, such as early-init/boot > > integrity logs with. Therefore, make ADUITSYSCALL optional > > again, but keep it default y. > > > > Signed-off-by: Frederick Lawler > > --- > > init/Kconfig | 11 ++++++++--- > > 1 file changed, 8 insertions(+), 3 deletions(-) > > Generally speaking the less Kconfig knobs the better; it tends to > complicate things and for those that rely on distro kernels, there is > always at least one group that is going to be upset about the Kconfig > knob being set "wrong". In my ideal world, CONFIG_AUDITSYSCALL wouldn't > exist at all, but sadly not all arches have the necessary support to > do that at the moment, so CONFIG_AUDITSYSCALL remains a necessary evil. > > Thank you for the patch, but IMO this is not the direction we want to > go with audit. > Thanks for the response. I think setting the filters to never would be OK, but doesn't hurt to try to see if it's worth squeezing out the remaining usages. > -- > paul-moore.com PS. I'll be sure to use b4 next time for a submission. Best, Fred