From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C524A1A2547 for ; Thu, 28 Aug 2025 00:48:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756342115; cv=none; b=rUImNZ2BumT8UiEUG92t7ZRZavEeangJUEhAkqw1CnHw4j5GOrj4bUU6X/BUN0TazSmtiM3tRSrkck2nDRAqsvpKAuIGTmhMIroZPxfGfoN1cyNwsJQsvU4tzSDHQ9dv5wza/q1Ya2BbNRMPLgEqBdrItcg7SYt+xSFNodc8Ww4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756342115; c=relaxed/simple; bh=jPOIqbaX5otSp3WzbbT+2/pxImfuTWJ2OFYKS4TvNE8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WDHDsmrIujnuemg9bXKACBWjf8lhYOAVbtp0jZerCw5GW577grUveZEqwkkGEuzgDzenEYBXDFllIwJxMTab+KXJzmci5PEeJ2yhD5X0yG9OJJVQXkMDHHWxA6jj+ugmxk0fAxuSGWcj9bYcofIFGDmRg8CJfXbY3YvMznT6D4k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=A0+S7ZMt; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="A0+S7ZMt" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756342112; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NH9M6qZ2J3KuMglksIXSkpXqc4X5PSXSXDDN9tN7Sr0=; b=A0+S7ZMtEqMcZBZpdKvQQ3aeFP9TuosYv2cGNkdBesN2OhFeHQzgG/KDeqxKwbK7pSiGOj EAoD7Fp+kXf4bgdVpMelXlFEVMp5KESYhbKhQvvIaX2HF7+GQL6r02bSPWjGpmjjGsXfzc 3tYbOIAhxQgDswWbyyGggGf6vOS3gsQ= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-417-CQAOlXZZMKejLbKb2rtedw-1; Wed, 27 Aug 2025 20:48:30 -0400 X-MC-Unique: CQAOlXZZMKejLbKb2rtedw-1 X-Mimecast-MFC-AGG-ID: CQAOlXZZMKejLbKb2rtedw_1756342108 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C46591956087; Thu, 28 Aug 2025 00:48:27 +0000 (UTC) Received: from fedora (unknown [10.72.116.22]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4B89B180028A; Thu, 28 Aug 2025 00:48:20 +0000 (UTC) Date: Thu, 28 Aug 2025 08:48:16 +0800 From: Ming Lei To: Sidong Yang Cc: Jens Axboe , Daniel Almeida , Caleb Sander Mateos , Benno Lossin , Miguel Ojeda , Arnd Bergmann , Greg Kroah-Hartman , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, io-uring@vger.kernel.org Subject: Re: [RFC PATCH v3 5/5] samples: rust: Add `uring_cmd` example to `rust_misc_device` Message-ID: References: <20250822125555.8620-1-sidong.yang@furiosa.ai> <20250822125555.8620-6-sidong.yang@furiosa.ai> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250822125555.8620-6-sidong.yang@furiosa.ai> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 On Fri, Aug 22, 2025 at 12:55:55PM +0000, Sidong Yang wrote: > This patch extends the `rust_misc_device` sample to demonstrate how to > use the `uring_cmd` interface for asynchronous device operations. > > The new implementation handles two `uring_cmd` operations: > > * `RUST_MISC_DEV_URING_CMD_SET_VALUE`: Sets a value in the device. > * `RUST_MISC_DEV_URING_CMD_GET_VALUE`: Gets a value from the device. > > To use this new functionality, users can submit `IORING_OP_URING_CMD` > operations to the `rust_misc_device` character device. > > Signed-off-by: Sidong Yang > --- > samples/rust/rust_misc_device.rs | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/samples/rust/rust_misc_device.rs b/samples/rust/rust_misc_device.rs > index e7ab77448f75..1f25d2b1f4d8 100644 > --- a/samples/rust/rust_misc_device.rs > +++ b/samples/rust/rust_misc_device.rs > @@ -101,6 +101,7 @@ > c_str, > device::Device, > fs::File, > + io_uring::IoUringCmd, > ioctl::{_IO, _IOC_SIZE, _IOR, _IOW}, > miscdevice::{MiscDevice, MiscDeviceOptions, MiscDeviceRegistration}, > new_mutex, > @@ -114,6 +115,9 @@ > const RUST_MISC_DEV_GET_VALUE: u32 = _IOR::('|' as u32, 0x81); > const RUST_MISC_DEV_SET_VALUE: u32 = _IOW::('|' as u32, 0x82); > > +const RUST_MISC_DEV_URING_CMD_SET_VALUE: u32 = _IOR::('|' as u32, 0x83); > +const RUST_MISC_DEV_URING_CMD_GET_VALUE: u32 = _IOW::('|' as u32, 0x84); > + > module! { > type: RustMiscDeviceModule, > name: "rust_misc_device", > @@ -192,6 +196,29 @@ fn ioctl(me: Pin<&RustMiscDevice>, _file: &File, cmd: u32, arg: usize) -> Result > > Ok(0) > } > + > + fn uring_cmd( > + me: Pin<&RustMiscDevice>, > + io_uring_cmd: Pin<&mut IoUringCmd>, > + _issue_flags: u32, > + ) -> Result { > + dev_info!(me.dev, "UringCmd Rust Misc Device Sample\n"); > + > + let cmd = io_uring_cmd.cmd_op(); > + let addr: usize = io_uring_cmd.sqe().cmd_data()?; > + let user_ptr = UserPtr::from_addr(addr); > + let user_slice = UserSlice::new(user_ptr, 8); > + > + match cmd { > + RUST_MISC_DEV_URING_CMD_SET_VALUE => me.set_value(user_slice.reader())?, > + RUST_MISC_DEV_URING_CMD_GET_VALUE => me.get_value(user_slice.writer())?, > + _ => { > + dev_err!(me.dev, "-> uring_cmd not recognised: {}\n", cmd); > + return Err(ENOTTY); > + } > + }; > + Ok(0) > + } > } I'd suggest to cover most of methods added in patch 2, so that any kernel side change can be verified easily. Thanks, Ming