From: Christoph Hellwig <hch@infradead.org>
To: Jinliang Zheng <alexjlzheng@gmail.com>
Cc: hch@infradead.org, alexjlzheng@tencent.com, brauner@kernel.org,
djwong@kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
yi.zhang@huawei.com
Subject: Re: [PATCH v3 0/4] allow partial folio write with iomap_folio_state
Date: Tue, 26 Aug 2025 06:20:13 -0700 [thread overview]
Message-ID: <aK20jalLkbKedAz8@infradead.org> (raw)
In-Reply-To: <20250825113921.2933350-1-alexjlzheng@tencent.com>
On Mon, Aug 25, 2025 at 07:39:21PM +0800, Jinliang Zheng wrote:
> Actually, I discovered this while reading (and studying) the code for large
> folios.
>
> Given that short-writes are inherently unusual, I don't think this patchset
> will significantly improve performance in hot paths. It might help in scenarios
> with frequent memory hardware errors, but unfortunately, I haven't built a
> test scenario like that.
>
> I'm posting this patchset just because I think we can do better in exception
> handling: if we can reduce unnecessary copying, why not?
I'm always interested in the motivation, especially for something
adding more code or doing large changes. If it actually improves
performance it's much easier to argue for. If it doesn't that doesn't
mean the patch is bad, but it needs to have other upsides. I'll take
another close look, but please also add your motivation to the cover
letter and commit log for the next round.
prev parent reply other threads:[~2025-08-26 13:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 9:15 [PATCH v3 0/4] allow partial folio write with iomap_folio_state alexjlzheng
2025-08-12 9:15 ` [PATCH v3 1/4] iomap: make sure iomap_adjust_read_range() are aligned with block_size alexjlzheng
2025-08-12 9:15 ` [PATCH v3 2/4] iomap: move iter revert case out of the unwritten branch alexjlzheng
2025-08-12 9:15 ` [PATCH v3 3/4] iomap: make iomap_write_end() return the number of written length again alexjlzheng
2025-08-12 9:15 ` [PATCH v3 4/4] iomap: don't abandon the whole copy when we have iomap_folio_state alexjlzheng
2025-08-25 6:41 ` [PATCH v3 0/4] allow partial folio write with iomap_folio_state Jinliang Zheng
2025-08-25 9:34 ` Christoph Hellwig
2025-08-25 11:39 ` Jinliang Zheng
2025-08-26 13:20 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aK20jalLkbKedAz8@infradead.org \
--to=hch@infradead.org \
--cc=alexjlzheng@gmail.com \
--cc=alexjlzheng@tencent.com \
--cc=brauner@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).