From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: "Adrian Barnaś" <abarnas@google.com>
Cc: Hans de Goede <hansg@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Andy Shevchenko <andy@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dan Carpenter <dan.carpenter@linaro.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH 1/4] staging: media: atomisp: Remove unnecessary forward declarations
Date: Tue, 26 Aug 2025 18:02:20 +0300 [thread overview]
Message-ID: <aK3MfAbTa49C8Rqo@smile.fi.intel.com> (raw)
In-Reply-To: <20250826104414.2817514-1-abarnas@google.com>
On Tue, Aug 26, 2025 at 10:44:11AM +0000, Adrian Barnaś wrote:
> Get rid of fifo_monitor_status_valid() and fifo_monitor_status_accept()
> forward declaration because it brings no value.
If you send more than one patch, get used to cover letter.
My script [1] does this for me, so I won't forget doing it.
Also one may use `b4 relay`.
[1]: https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh
The patch series (all patches) LGTM,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
...
> + return (data >> (((port_id * 2) + _hive_str_mon_valid_offset))) & 0x1;
Side note, perhaps change this (in a separate followup) to
return data & BIT(port_id * 2 + _hive_str_mon_valid_offset);
It will significantly increase readability.
...
> + return (data >> (((port_id * 2) + _hive_str_mon_accept_offset))) & 0x1;
In the same way
return data & BIT(port_id * 2 + _hive_str_mon_accept_offset);
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-08-26 15:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-26 10:44 [PATCH 1/4] staging: media: atomisp: Remove unnecessary forward declarations Adrian Barnaś
2025-08-26 10:44 ` [PATCH 2/4] staging: media: atomisp: Whitespaces style cleanup in fifo_monitor.c Adrian Barnaś
2025-08-26 10:44 ` [PATCH 3/4] staging: media: atomisp: Remove returns from end of void functions Adrian Barnaś
2025-08-26 10:44 ` [PATCH 4/4] staging: media: atomisp: Whitespaces style fixes Adrian Barnaś
2025-08-26 15:02 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aK3MfAbTa49C8Rqo@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=abarnas@google.com \
--cc=andy@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).