From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Dixit Parmar <dixitparmar19@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v4 1/2] iio: magnetometer: add support for Infineon TLV493D 3D Magentic sensor
Date: Wed, 20 Aug 2025 16:56:12 +0300 [thread overview]
Message-ID: <aKXT_HOrY1XUlsLu@smile.fi.intel.com> (raw)
In-Reply-To: <aKVTJXe50zf07ipR@dixit>
On Wed, Aug 20, 2025 at 10:16:29AM +0530, Dixit Parmar wrote:
> On Sat, Aug 16, 2025 at 02:04:48PM +0100, Jonathan Cameron wrote:
...
> > > + TLV493D_AXIS_X,
> > > + TLV493D_AXIS_Y,
> > > + TLV493D_AXIS_Z,
> > > + TLV493D_TEMPERATURE
> > As below.
> >
> > > +};
> > > +
> > > +enum tlv493d_op_mode {
> > > + TLV493D_OP_MODE_POWERDOWN,
> > > + TLV493D_OP_MODE_FAST,
> > > + TLV493D_OP_MODE_LOWPOWER,
> > > + TLV493D_OP_MODE_ULTRA_LOWPOWER,
> > > + TLV493D_OP_MODE_MASTERCONTROLLED
> > This is not a terminating entry, so would typically have a trailing comma.
> Isn't the last entry in the enum list is termintating entry and it should
> not have trailing comma?
No, it's not semantically. (Yes, it's terminating the list syntactically)
> > > +};
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-08-20 13:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-14 2:53 [PATCH v4 0/2] iio: magnetometer: add support for Infineon TLV493D 3D Magnetic Sensor Dixit Parmar
2025-08-14 2:53 ` [PATCH v4 1/2] iio: magnetometer: add support for Infineon TLV493D 3D Magentic sensor Dixit Parmar
2025-08-16 13:04 ` Jonathan Cameron
2025-08-20 4:46 ` Dixit Parmar
2025-08-20 13:56 ` Andy Shevchenko [this message]
2025-08-20 14:08 ` Andy Shevchenko
2025-08-21 3:02 ` Dixit Parmar
2025-08-21 7:41 ` Andy Shevchenko
2025-08-22 2:40 ` Dixit Parmar
2025-08-22 6:11 ` Andy Shevchenko
2025-08-25 3:03 ` Dixit Parmar
2025-08-25 9:50 ` Jonathan Cameron
2025-08-26 2:52 ` Dixit Parmar
2025-08-26 3:02 ` Dixit Parmar
2025-08-30 14:53 ` Jonathan Cameron
2025-08-14 2:53 ` [PATCH v4 2/2] dt-bindings: iio: magnetometer: document Infineon TLV493D 3D Magnetic sensor Dixit Parmar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKXT_HOrY1XUlsLu@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dixitparmar19@gmail.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).