From: Andrea Righi <arighi@nvidia.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Joel Fernandes <joelagnelf@nvidia.com>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
Tejun Heo <tj@kernel.org>, David Vernet <void@manifault.com>,
Changwoo Min <changwoo@igalia.com>,
Luigi De Matteis <ldematteis123@gmail.com>,
sched-ext@lists.linux.dev
Subject: Re: [PATCH -rebased 07/15] sched_ext: Add a DL server for sched_ext tasks
Date: Wed, 20 Aug 2025 17:52:16 +0200 [thread overview]
Message-ID: <aKXvMAdSvNcVAa4O@gpd4> (raw)
In-Reply-To: <20250819075714.GE3245006@noisy.programming.kicks-ass.net>
On Tue, Aug 19, 2025 at 09:57:14AM +0200, Peter Zijlstra wrote:
> On Sat, Aug 09, 2025 at 02:47:52PM -0400, Joel Fernandes wrote:
>
> > --- a/kernel/sched/deadline.c
> > +++ b/kernel/sched/deadline.c
> > @@ -1510,7 +1510,7 @@ static void update_curr_dl_se(struct rq *rq, struct sched_dl_entity *dl_se, s64
> > * The fair server (sole dl_server) does not account for real-time
> > * workload because it is running fair work.
> > */
> > - if (dl_se == &rq->fair_server)
> > + if (dl_se == &rq->fair_server || dl_se == &rq->ext_server)
> > return;
>
> Does that want to be: if (dl_se->dl_server) ?
Makes sense to me.
I just tested it (even added a WARN_ON() to be 100% sure the check is
equivalent), and everything seems to work as expected.
Thanks!
-Andrea
next prev parent reply other threads:[~2025-08-20 15:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-09 18:47 [PATCH -rebased 00/15] Add a deadline server for sched_ext tasks Joel Fernandes
2025-08-09 18:47 ` [PATCH -rebased 01/15] sched/debug: Fix updating of ppos on server write ops Joel Fernandes
2025-08-09 18:47 ` [PATCH -rebased 02/15] sched/debug: Stop and start server based on if it was active Joel Fernandes
2025-08-09 18:47 ` [PATCH -rebased 03/15] sched/deadline: Clear the defer params Joel Fernandes
2025-08-09 18:47 ` [PATCH -rebased 04/15] sched/deadline: Return EBUSY if dl_bw_cpus is zero Joel Fernandes
2025-08-09 18:47 ` [PATCH -rebased 05/15] sched: Add support to pick functions to take rf Joel Fernandes
2025-08-09 18:47 ` [PATCH -rebased 06/15] sched: Add a server arg to dl_server_update_idle_time() Joel Fernandes
2025-08-09 18:47 ` [PATCH -rebased 07/15] sched_ext: Add a DL server for sched_ext tasks Joel Fernandes
2025-08-19 7:57 ` Peter Zijlstra
2025-08-20 15:52 ` Andrea Righi [this message]
2025-08-20 17:52 ` Joel Fernandes
2025-08-20 18:19 ` Andrea Righi
2025-08-09 18:47 ` [PATCH -rebased 08/15] sched/debug: Add support to change sched_ext server params Joel Fernandes
2025-08-09 18:47 ` [PATCH -rebased 09/15] sched/deadline: Add support to remove DL server's bandwidth contribution Joel Fernandes
2025-08-09 18:47 ` [PATCH -rebased 10/15] sched/deadline: Account ext server bandwidth Joel Fernandes
2025-08-09 18:47 ` [PATCH -rebased 11/15] sched/deadline: Allow to initialize DL server when needed Joel Fernandes
2025-08-09 18:47 ` [PATCH -rebased 12/15] sched_ext: Selectively enable ext and fair DL servers Joel Fernandes
2025-08-09 18:47 ` [PATCH -rebased 13/15] sched/deadline: Fix DL server crash in inactive_timer callback Joel Fernandes
2025-08-09 18:47 ` [PATCH -rebased 14/15] selftests/sched_ext: Add test for sched_ext dl_server Joel Fernandes
2025-08-09 18:48 ` [PATCH -rebased 15/15] selftests/sched_ext: Add test for DL server total_bw consistency Joel Fernandes
2025-08-13 9:15 ` [PATCH -rebased 00/15] Add a deadline server for sched_ext tasks Juri Lelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKXvMAdSvNcVAa4O@gpd4 \
--to=arighi@nvidia.com \
--cc=bsegall@google.com \
--cc=changwoo@igalia.com \
--cc=dietmar.eggemann@arm.com \
--cc=joelagnelf@nvidia.com \
--cc=juri.lelli@redhat.com \
--cc=ldematteis123@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sched-ext@lists.linux.dev \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=void@manifault.com \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox