From: Cristian Marussi <cristian.marussi@arm.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Cristian Marussi <cristian.marussi@arm.com>,
Deepti Jaggi <quic_djaggi@quicinc.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@oss.qualcomm.com, Nikunj Kela <quic_nkela@quicinc.com>
Subject: Re: [PATCH v6] dt-bindings: firmware: arm,scmi: allow multiple instances
Date: Thu, 21 Aug 2025 09:52:21 +0100 [thread overview]
Message-ID: <aKbeRVsLpXcpiyHb@pluto> (raw)
In-Reply-To: <a59908c9-38d8-492d-9e3f-5560d272689b@linaro.org>
On Thu, Aug 21, 2025 at 10:29:00AM +0200, Krzysztof Kozlowski wrote:
> On 21/08/2025 10:04, Cristian Marussi wrote:
> > On Wed, Aug 20, 2025 at 11:44:26AM -0700, Deepti Jaggi wrote:
> >>
> >> On 7/30/25 14:30, Deepti Jaggi wrote:
> >>> From: Nikunj Kela <quic_nkela@quicinc.com>
> >>>
> >
> > Hi,
> >
> >>> Allow multiple SCMI instances by extending the scmi node name to include
> >>> an instance number suffix.
> >>>
> >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >>> Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>
> >>> Signed-off-by: Nikunj Kela <quic_nkela@quicinc.com>
> >>> Signed-off-by: Deepti Jaggi <quic_djaggi@quicinc.com>
> >>> ---
> >>> Changes in v6:
> >>> - Dropped 'this change' from description
> >>> - Link to v5: https://lore.kernel.org/all/20250423005824.3993256-1-quic_djaggi@quicinc.com
> >>>
> >>> Changes in v5:
> >>> - Added Reviewed-by tag
> >>> - Link to v4: https://lore.kernel.org/all/20240910163456.2383372-1-quic_nkela@quicinc.com
> >>>
> >>> Changes in v4:
> >>> - Dropped 'virtual' from subject and description
> >>> - Link to v3: https://lore.kernel.org/all/20240905201217.3815113-1-quic_nkela@quicinc.com
> >>>
> >>> Changes in v3:
> >>> - Added Reviewed-by tag
> >>> - Removed the patch from original series[1]
> >>>
> >>> Changes in v2:
> >>> - Fixed scmi nodename pattern
> >>>
> >>> [1]: https://lore.kernel.org/all/20240903220240.2594102-1-quic_nkela@quicinc.com/
> >>> ---
> >>> Documentation/devicetree/bindings/firmware/arm,scmi.yaml | 2 +-
> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> >>> index abbd62f1fed0993ab98fa44bdb9a0575f8e1c78e..be817fd9cc34b14009a3b1d69e78b802215571b6 100644
> >>> --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> >>> +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> >>> @@ -27,7 +27,7 @@ anyOf:
> >>> properties:
> >>> $nodename:
> >>> - const: scmi
> >>> + pattern: '^scmi(-[0-9]+)?$'
> >>> compatible:
> >>> oneOf:
> >>>
> >>> ---
> >>> base-commit: 0b90c3b6d76ea512dc3dac8fb30215e175b0019a
> >>> change-id: 20250728-8255-scmi-ed963ef8f155
> >>
> >> Gentle ping!!
>
> You cannot ping gently while screaming!!! (you see how gentle this feels?)
>
> >> Could you please review the patch?
> >>
> >
> > I thought this was already reviewed/acked and merged since ages....
> > ...also the wording-change in the commit message LGTM.
> >
> > Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>
>
> It was. Twice! This is just unjustified ping.
I'd like to add a new tag at this point.
Reviewed-!!-by-!!: Cristian Marussi <cristian.marussi@arm.com>
:P
Cheers,
Cristian
next prev parent reply other threads:[~2025-08-21 8:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-30 21:30 [PATCH v6] dt-bindings: firmware: arm,scmi: allow multiple instances Deepti Jaggi
2025-08-20 18:44 ` Deepti Jaggi
2025-08-21 8:04 ` Cristian Marussi
2025-08-21 8:29 ` Krzysztof Kozlowski
2025-08-21 8:52 ` Cristian Marussi [this message]
2025-08-21 10:09 ` Sudeep Holla
2025-08-22 21:21 ` Deepti Jaggi
2025-08-26 10:39 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKbeRVsLpXcpiyHb@pluto \
--to=cristian.marussi@arm.com \
--cc=arm-scmi@vger.kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_djaggi@quicinc.com \
--cc=quic_nkela@quicinc.com \
--cc=robh@kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).