From: Sudeep Holla <sudeep.holla@arm.com>
To: Xichao Zhao <zhao.xichao@vivo.com>
Cc: <cristian.marussi@arm.com>, <jassisinghbrar@gmail.com>,
Sudeep Holla <sudeep.holla@arm.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mailbox: arm_mhuv3: Remove dev_err_probe() if error is -ENOMEM
Date: Thu, 21 Aug 2025 10:53:18 +0100 [thread overview]
Message-ID: <aKbsjmEnXIOka7QM@bogus> (raw)
In-Reply-To: <20250821093253.559809-1-zhao.xichao@vivo.com>
On Thu, Aug 21, 2025 at 05:32:53PM +0800, Xichao Zhao wrote:
> The dev_err_probe() doesn't do anything when error is '-ENOMEM'.
> Therefore, remove the useless call to dev_err_probe(), and just
> return the value instead.
>
While I understand that it doesn't print the message for ENOMEM,
grep dev_err_probe.*ENOMEM | wc -l
gave be 80 results, so not keen in just getting rid of one instance only.
No strong objection either if the subsystem maintainer prefers it this way.
--
Regards,
Sudeep
next prev parent reply other threads:[~2025-08-21 9:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-21 9:32 [PATCH] mailbox: arm_mhuv3: Remove dev_err_probe() if error is -ENOMEM Xichao Zhao
2025-08-21 9:53 ` Sudeep Holla [this message]
2025-08-21 10:00 ` Cristian Marussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKbsjmEnXIOka7QM@bogus \
--to=sudeep.holla@arm.com \
--cc=cristian.marussi@arm.com \
--cc=jassisinghbrar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zhao.xichao@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox