From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4008532BF50 for ; Thu, 21 Aug 2025 13:29:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755782977; cv=none; b=Ww3RnsyI+rqEVDeQ2xMBwnMRD9z//e1H5gvMYXCDwUaIzQruWtqFbCuXcxhBejtMZUbFMC31N9hYytde+qpvtBctnfMAlw4YTYexD8B6LhhCyWsy/vwDwD2D1TOQO7foPTaMp1i+wgCdF3eL6qlCuyAcdD7uaFeJBrS3FTEI+dw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755782977; c=relaxed/simple; bh=wc5v9uTTIL728+hB7UJTKaDvwgtQwqhmi3Vl/hFU5ak=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JZdbFSrBANc4gu8VZrmWt5ByjSR0ZXhj5JDmNNW8qgI2Hh/b9Mvoz3W1B5DPkSxS5Cdjambs6rXxd5LO3IEW8WwZRRENCXJqWGr+ZIDVlxw7VQeG+POsk+ESF5vm8X6O0wssd/RupY3REHQJ6NECcObUwexKVLYf1+h0WZdVTlA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=WjckZDPu; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="WjckZDPu" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-24611734e50so83575ad.1 for ; Thu, 21 Aug 2025 06:29:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1755782975; x=1756387775; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=J13Esd7nTONrArlNpUKcH+9/JHXUHsKEy/Ib89aPaCQ=; b=WjckZDPuo7y3Xh8jJTXxR+MBh9aWmoKvkLNd0tcrZtigIT2fPZ2vi94ZoJMZl9dgv/ VtoNsQPws+ioJBCOI9Y/Kmqbfd+YXVnue2vpoZH4Fv0XW5JqqdwEnoR0poRFBbLeEKn6 ljtT5o4Q05byKB714hFG2EoUVQEx04JRW+ESAGCTmkqY/DKcloSPi9bFlsy9fSkAPnTK 2ocCKCzcWsRXpBD5wjKi2vyO1VrVMclcC0nPaOw/p16X70FE9z3QlPhl/SjeyEDdaapJ aFhzYxIVeJ/TWNgk4rwWMl06bF+RDyeMS3vOMCUXZzOLkoJD1BMxoQ4fV1jAE4QuTm/N qm1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755782975; x=1756387775; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=J13Esd7nTONrArlNpUKcH+9/JHXUHsKEy/Ib89aPaCQ=; b=OBm0Ojwp2IdkXd0gctAEQMxBrveodH8YWNmgcWLPSX8FtQGsgbGJJvi/7T09k49OVx UVNpFBcQiqWe9FIVwENkorw0AFmKSCc68lI1ScecCjeCRKpqBqlMHo3OCR67sZQs0OgU lKiSlZcQgtxipu+bH0BPcCyDRqhiYYjI9SF1vOywYkyxdZ7Cume+Y7wWow9yW9Wqshee SfEJ4z7KcPMUKrvbywsQAZ2jqUY0gs5kAcT9zv5tUrD3Gk7KIH4g/Hb22oFlpNi9hWIu b7jHpN7VW5Qq5IOdxRIGbkPy/OkOpun8WtKgVq0f5Rzwiv3aG7Hy1cMZg3GcNuxnDl01 OFCA== X-Forwarded-Encrypted: i=1; AJvYcCV1bthGCfEWQKS0NzGDLgetF9XEgC3jRAbYJAhAObEKx+lHQcdLHbyC93A3GkYbtgJ9HZGm4BwC5SVPcuY=@vger.kernel.org X-Gm-Message-State: AOJu0YzY1jFptgNb+4lAlapTm+ilOaljG2AXeZCNhgH88Zd+aG8WUW6u lGo/346fueA0m7zb6vOVgTjR5P98GWOahK0XMr8Qq+ty2dfHLGBbqx+CUvaynxKU5w== X-Gm-Gg: ASbGncuDE+xa4Bn5uVx9AAJX7uHCQxo7De6RHiuObJV6j1eQXZommpVc4L+TiTrQY6X esSHCOTT07V9oDYmDrxFnT8xHm5ykupjIkjIZvu+cgbieMgR5113ayd/zhYm5UWQyAE6MudVPFk J9f9xw3WQatK0kBYMJCZoREPnA+w83YGbLhh49VKXorlJFFUj8wDl0mVATx+IX/OBV+FwqxevoN XOHbDlC7bKyaSa7fKm0zm5j6/k2Hab/+654TvjQ8NXBTXrOF0pKC4dasUAvm46i7VieIB5IPWNi R7PbiJFHR3knioOrV7TBxw3rUGDnd/xWmbbLQUgVTQhzKMysEI2C7DT4LFcxJXY0VPcWM5Ev9Qv WRqOVJuQ2xltaNc2Sw4vHVjCp3Yx8YM5n17e/yjY9w04WF1+Ea0DO3VpWhl3XqA== X-Google-Smtp-Source: AGHT+IEJ89+AicE1lZQ3XnhpL5tHd/m1IsnyOgUW94AR1BOA58fjSEzDksF9jqNKQwq8P3RC6Erj0g== X-Received: by 2002:a17:903:166e:b0:234:b441:4d4c with SMTP id d9443c01a7336-24602317afcmr3273645ad.5.1755782975217; Thu, 21 Aug 2025 06:29:35 -0700 (PDT) Received: from google.com (3.32.125.34.bc.googleusercontent.com. [34.125.32.3]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-76e7d4fd2f5sm8344077b3a.74.2025.08.21.06.29.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Aug 2025 06:29:34 -0700 (PDT) Date: Thu, 21 Aug 2025 13:29:29 +0000 From: Carlos Llamas To: Thorsten Leemhuis Cc: Greg Kroah-Hartman , Li Li , Tiffany Yang , John Stultz , Shai Barack , =?iso-8859-1?Q?Thi=E9baud?= Weksteen , kernel-team@android.com, linux-kernel@vger.kernel.org, "David S. Miller" , Joel Fernandes , Todd Kjos , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Donald Hunter , Christian Brauner , Eric Dumazet , "open list:NETWORKING [GENERAL]" , Martijn Coenen , Stephen Rothwell , Linux Next Mailing List , Jakub Kicinski , Linux kernel regressions list , Alice Ryhl , Suren Baghdasaryan , Paolo Abeni , Simon Horman Subject: Re: [PATCH v20 3/5] binder: introduce transaction reports via netlink Message-ID: References: <20250727182932.2499194-1-cmllamas@google.com> <20250727182932.2499194-4-cmllamas@google.com> <2025082145-crabmeat-ounce-e71f@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Aug 21, 2025 at 03:00:50PM +0200, Thorsten Leemhuis wrote: > On 21.08.25 14:19, Greg Kroah-Hartman wrote: > > On Thu, Aug 21, 2025 at 10:49:09AM +0200, Thorsten Leemhuis wrote: > >> On 27.07.25 20:29, Carlos Llamas wrote: > >>> From: Li Li > >>> > >>> Introduce a generic netlink multicast event to report binder transaction > >>> failures to userspace. This allows subscribers to monitor these events > >>> and take appropriate actions, such as stopping a misbehaving application > >>> that is spamming a service with huge amount of transactions. > >>> > >>> The multicast event contains full details of the failed transactions, > >>> including the sender/target PIDs, payload size and specific error code. > >>> This interface is defined using a YAML spec, from which the UAPI and > >>> kernel headers and source are auto-generated. > >> > >> It seems to me like this patch (which showed up in -next today after > >> Greg merged it) caused a build error for me in my daily -next builds > >> for Fedora when building tools/net/ynl: > >> > >> """ > >> make[1]: Entering directory '/home/kbuilder/ark-vanilla/linux-knurd42/tools/net/ynl/lib' > >> gcc -std=gnu11 -O2 -W -Wall -Wextra -Wno-unused-parameter -Wshadow -c -MMD -c -o ynl.o ynl.c > >> AR ynl.a > >> make[1]: Leaving directory '/home/kbuilder/ark-vanilla/linux-knurd42/tools/net/ynl/lib' > >> make[1]: Entering directory '/home/kbuilder/ark-vanilla/linux-knurd42/tools/net/ynl/generated' > >> GEN binder-user.c > >> Traceback (most recent call last): > >> File "/home/kbuilder/ark-vanilla/linux-knurd42/tools/net/ynl/generated/../pyynl/ynl_gen_c.py", line 3673, in > >> main() > >> ~~~~^^ > >> File "/home/kbuilder/ark-vanilla/linux-knurd42/tools/net/ynl/generated/../pyynl/ynl_gen_c.py", line 3382, in main > >> parsed = Family(args.spec, exclude_ops) > >> File "/home/kbuilder/ark-vanilla/linux-knurd42/tools/net/ynl/generated/../pyynl/ynl_gen_c.py", line 1205, in __init__ > >> super().__init__(file_name, exclude_ops=exclude_ops) > >> ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > >> File "/home/kbuilder/ark-vanilla/linux-knurd42/tools/net/ynl/pyynl/lib/nlspec.py", line 462, in __init__ > >> jsonschema.validate(self.yaml, schema) > >> ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^ > >> File "/usr/lib/python3.13/site-packages/jsonschema/validators.py", line 1307, in validate > >> raise error > >> jsonschema.exceptions.ValidationError: 'from_pid' does not match '^[0-9a-z-]+$' > >> > >> Failed validating 'pattern' in schema['properties']['attribute-sets']['items']['properties']['attributes']['items']['properties']['name']: > >> {'pattern': '^[0-9a-z-]+$', 'type': 'string'} > >> > >> On instance['attribute-sets'][0]['attributes'][2]['name']: > >> 'from_pid' > >> make[1]: *** [Makefile:48: binder-user.c] Error 1 > >> make[1]: Leaving directory '/home/kbuilder/ark-vanilla/linux-knurd42/tools/net/ynl/generated' > >> make: *** [Makefile:25: generated] Error 2 > >> """ > > > > Odd, this works for me. > > Hmmm, happened on various Fedora releases and archs in Fedora's coprs > buildsys for me today. And with a local Fedora 41 x86_64 install, too; > in the latter case (just verified) both when checking out next-20250821 > and 63740349eba78f ("binder: introduce transaction reports via netlink") > from -next. > > > How exactly are you building this? > > Just "cd tools/net/ynl; make". > > Ciao, Thorsten Judging by the regex in the error log it seems there is a new restriction to not using underscores in the yml files. This restriction probably raced with my patch in next. It should be very easy to fix. Can you please try replacing the underscores? $ sed -i 's/_/-/' Documentation/netlink/specs/binder.yaml I think that should fix your build. I'll try to reproduce. -- Carlos Llamas