From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2D242DF70B for ; Thu, 21 Aug 2025 13:39:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755783543; cv=none; b=ar/pKgQ0za+UmLYcNo4nubyDyE65J4SSsR1q88Eiq/P/v3/D7cTe4NTSyjzBBVAz9C6lJPbcBCqpb1jx/TNAFelQcra7MqtkPihsBKsXuSX8eIVs8CU+sfqGaM9PXHeJaTZCheVJ3ORFiYOEnu5161hE4G6NX7r+EZq2gs6yCvM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755783543; c=relaxed/simple; bh=UBaomgbe5Pto6k9s8jcQN8o0bdH3iMYe1oFhKjAp01M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=W5H6GhDWJe4auLUeNDpR18diL0Slw3jVmHukl6UrdisN1KLFxWVDsuCSyrXpHu1BI7NVkjZs0KiISny5Ih9ZSEZStT/mPvHh//6rQisCpIMabtMApVfh1v9wh5sKewcXhZM8cDDq8qy1baUXZwSMQBto2mcnI5z8EDdOoVRhZB0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=n5pFRIfr; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="n5pFRIfr" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-24611734e50so85005ad.1 for ; Thu, 21 Aug 2025 06:39:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1755783541; x=1756388341; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7N9rAjjjlmmVnsb6lYyZUzYXQ/m0Q5K6qvsrUkhsgXc=; b=n5pFRIfrtJN7JZMXIcg9FomDpqXm35VXUOT0hHV/Me6jKlY0VGZ6heo6dKmBQtWU7d 9bw5evGgGCIQmKNMxyqbBxGDt87FjTTovsleJabaYL0nDPksutu1SF8GB/F4RtzIkHry GtjiW4h88UiidARPei+Tz2CwcX4eA6iIh+hJcZNorbPgyZt/R5rXN5dMbs8m+RF+vWpc S/IVfFbU5QkJ0co8umVuGSWm1i2/p9/FmPX0rhniYXWJ16s/qPu5v+0xYZdxML6sF503 l/GDYJ81+nZHoZqFThJxolc3FLAZDlJsshBfAm+vO5jc42Hg3ofoS6L8+rlsx5C9pQH1 XLAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755783541; x=1756388341; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7N9rAjjjlmmVnsb6lYyZUzYXQ/m0Q5K6qvsrUkhsgXc=; b=JVdztJZhwBlAE60cYuDREstnDQB/s/aoJajL67ZiVYDfRuhGRVA5iOaBGc37quaIQt oMoAHBXnjTeFCYjks1M9oZUfPg51o5x2Vw3HjYAdm7ZXWoqpzB6LGnFhfyizvtsFlQjI pYMdbWCCoRxReqBr6qD1I99HitVtbGjnOQ1kxxmLItIA0nTZslLFomnKEgBUJnoM3i/2 3MU1wqURSOPDl2AZIot5tP46S1I/VCsWDJUgLDKX2wHi8IwzNSN5XE19bDs42C4hp+Uk VdPfU/enfOb15EX2vHxshB0uK3yskm8fUwtPZCcqEdgVZhEfdG6E01KyuR2iWn6+9cwP e9jA== X-Forwarded-Encrypted: i=1; AJvYcCXAGU/rLIWF23RWbebGy35HEd8UYa70SSi2fiK52s8nYVOtiuf9gVT0e7ey3NYvJ2E3PqsiJmbpsTcYp7k=@vger.kernel.org X-Gm-Message-State: AOJu0YzS6CRnZUxCyi6vYUrGcgJUevQbm3+ywRbTBIMXUPB/BsoN3Uhi VApxtWdXTF/Qzpkvw950eCCgR3Xt7dDU/N61Z8M1qT9Vj/AHbXuN0rCUCCsecb2Wqg== X-Gm-Gg: ASbGncsrTrMI9Kq9+TecNz5nmtybWQJ7uM9UPbCeqE4p708Cgos0BY5YTMSZIFdp2zO GKulkdSb1VAnjNoldeumE85LhCIvRSm+D2jQ4QI5nxnRZF6x7q0BLupcVP+Z+AqVl7exlI+11ld ITym2lV1hKTUnfKKlleaJvgDxl5Sv1iGdwacRWv5is4g6oRhs9xnYzl8ViJpz8ITveODBAZxZc2 OJFaFpCGbbQk39jxz3liPFzaJoVSTzRpj35SDTfK8t0RUVkUDMXZ0/QR9mLkb0wa63A6SeEcng9 TKMuhA+1NxFpDQDFUqH6kL9cRmWTabHY/3v4UUmnDIedaYiEiJXMfKdzUVPJD7uw2sVEs0qr2I3 lucWlyYJ4N6cKsybiJMtUHlnmDzgIKWXFuRPrbCgYxeYNELkyntvUgOFNK3/e4Q== X-Google-Smtp-Source: AGHT+IEC07DRM954ZauhrF271W70UI0dmUDeDFMbKiMegLnkkgTzAWcZdd3XdKKaCxDubRNrmCtS1g== X-Received: by 2002:a17:903:22d2:b0:240:a4b5:fe0d with SMTP id d9443c01a7336-245ffa5b6cbmr3398745ad.6.1755783540818; Thu, 21 Aug 2025 06:39:00 -0700 (PDT) Received: from google.com (3.32.125.34.bc.googleusercontent.com. [34.125.32.3]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b4763fb85e7sm4806942a12.12.2025.08.21.06.38.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Aug 2025 06:38:59 -0700 (PDT) Date: Thu, 21 Aug 2025 13:38:54 +0000 From: Carlos Llamas To: Greg Kroah-Hartman Cc: Thorsten Leemhuis , Li Li , Tiffany Yang , John Stultz , Shai Barack , =?iso-8859-1?Q?Thi=E9baud?= Weksteen , kernel-team@android.com, linux-kernel@vger.kernel.org, "David S. Miller" , Joel Fernandes , Todd Kjos , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Donald Hunter , Christian Brauner , Eric Dumazet , "open list:NETWORKING [GENERAL]" , Martijn Coenen , Stephen Rothwell , Linux Next Mailing List , Jakub Kicinski , Linux kernel regressions list , Alice Ryhl , Suren Baghdasaryan , Paolo Abeni , Simon Horman Subject: Re: [PATCH v20 3/5] binder: introduce transaction reports via netlink Message-ID: References: <20250727182932.2499194-1-cmllamas@google.com> <20250727182932.2499194-4-cmllamas@google.com> <2025082145-crabmeat-ounce-e71f@gregkh> <2025082120-phoney-husband-d028@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2025082120-phoney-husband-d028@gregkh> On Thu, Aug 21, 2025 at 03:25:59PM +0200, Greg Kroah-Hartman wrote: > On Thu, Aug 21, 2025 at 03:00:50PM +0200, Thorsten Leemhuis wrote: > > On 21.08.25 14:19, Greg Kroah-Hartman wrote: > > > On Thu, Aug 21, 2025 at 10:49:09AM +0200, Thorsten Leemhuis wrote: > > >> On 27.07.25 20:29, Carlos Llamas wrote: > > >>> From: Li Li > > >>> > > >>> Introduce a generic netlink multicast event to report binder transaction > > >>> failures to userspace. This allows subscribers to monitor these events > > >>> and take appropriate actions, such as stopping a misbehaving application > > >>> that is spamming a service with huge amount of transactions. > > >>> > > >>> The multicast event contains full details of the failed transactions, > > >>> including the sender/target PIDs, payload size and specific error code. > > >>> This interface is defined using a YAML spec, from which the UAPI and > > >>> kernel headers and source are auto-generated. > > >> > > >> It seems to me like this patch (which showed up in -next today after > > >> Greg merged it) caused a build error for me in my daily -next builds > > >> for Fedora when building tools/net/ynl: > > >> > > >> """ > > >> make[1]: Entering directory '/home/kbuilder/ark-vanilla/linux-knurd42/tools/net/ynl/lib' > > >> gcc -std=gnu11 -O2 -W -Wall -Wextra -Wno-unused-parameter -Wshadow -c -MMD -c -o ynl.o ynl.c > > >> AR ynl.a > > >> make[1]: Leaving directory '/home/kbuilder/ark-vanilla/linux-knurd42/tools/net/ynl/lib' > > >> make[1]: Entering directory '/home/kbuilder/ark-vanilla/linux-knurd42/tools/net/ynl/generated' > > >> GEN binder-user.c > > >> Traceback (most recent call last): > > >> File "/home/kbuilder/ark-vanilla/linux-knurd42/tools/net/ynl/generated/../pyynl/ynl_gen_c.py", line 3673, in > > >> main() > > >> ~~~~^^ > > >> File "/home/kbuilder/ark-vanilla/linux-knurd42/tools/net/ynl/generated/../pyynl/ynl_gen_c.py", line 3382, in main > > >> parsed = Family(args.spec, exclude_ops) > > >> File "/home/kbuilder/ark-vanilla/linux-knurd42/tools/net/ynl/generated/../pyynl/ynl_gen_c.py", line 1205, in __init__ > > >> super().__init__(file_name, exclude_ops=exclude_ops) > > >> ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > >> File "/home/kbuilder/ark-vanilla/linux-knurd42/tools/net/ynl/pyynl/lib/nlspec.py", line 462, in __init__ > > >> jsonschema.validate(self.yaml, schema) > > >> ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^ > > >> File "/usr/lib/python3.13/site-packages/jsonschema/validators.py", line 1307, in validate > > >> raise error > > >> jsonschema.exceptions.ValidationError: 'from_pid' does not match '^[0-9a-z-]+$' > > >> > > >> Failed validating 'pattern' in schema['properties']['attribute-sets']['items']['properties']['attributes']['items']['properties']['name']: > > >> {'pattern': '^[0-9a-z-]+$', 'type': 'string'} > > >> > > >> On instance['attribute-sets'][0]['attributes'][2]['name']: > > >> 'from_pid' > > >> make[1]: *** [Makefile:48: binder-user.c] Error 1 > > >> make[1]: Leaving directory '/home/kbuilder/ark-vanilla/linux-knurd42/tools/net/ynl/generated' > > >> make: *** [Makefile:25: generated] Error 2 > > >> """ > > > > > > Odd, this works for me. > > > > Hmmm, happened on various Fedora releases and archs in Fedora's coprs > > buildsys for me today. And with a local Fedora 41 x86_64 install, too; > > in the latter case (just verified) both when checking out next-20250821 > > and 63740349eba78f ("binder: introduce transaction reports via netlink") > > from -next. > > > > > How exactly are you building this? > > > > Just "cd tools/net/ynl; make". > > Odd, this works for me in the driver-core-next branch, but in linux-next > it blows up like this. Is it a merge issue somewhere? I don't know > what this tool is doing to attempt to debug it myself, sorry. > > greg k-h The commit enforcing the restriction on underscores is: af852f1f1c95 ("netlink: specs: enforce strict naming of properties") I'm able to reproduce the issue locally now, and switching to dashes fixes it. Sorry, I was not aware of this restriction but I'll send a quick patch to fix this. -- Carlos Llamas