From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9ECD62E762A for ; Fri, 22 Aug 2025 10:23:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755858240; cv=none; b=ffyntKhWRLGz13VSuQgFyF6SMOcyTFon3zkngeoEyBAQvHphcCUN6i+7ALwAroXxMHMjaAg2CYhU7qAupgsKp8tYApu4J2Jox8pPk0j6vbKWkBNQ1h3ffVtrh7709pizcEZGTuySnt+A21W4E+S9cJmNK58VWpJY3W/qvXkRt0g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755858240; c=relaxed/simple; bh=Pi24T1VzeRTeyxb78iSx9eOfruahP8bbLgZ7xrrxp9M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fbDQcjRuOPSLiEG6XQDFACMNA2QSBoM2VoMQCmD5i3mkT4VVipknLbaXBxAj9+jLoNc16SovmW1JQebXwY9OvWcU17071RQ4hQXHUC19VgLH4GIFp57CsJL44NY6QNiqvqtF7SjIVBEoMv6F/CxtZDX0aQfx8Pp/gFie383FdrY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=DbOyIrT0; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DbOyIrT0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1755858237; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eJvTKEyEbzhmekaQhrASqnfJY8OZgIJPjxsG4VBPz2I=; b=DbOyIrT0oo3LaxWkFj22kgDGX32LmZAJ6K90PumU/WTQ1QrCv57MdnQJWOEVVRJ2RYkUhX 07wLcaedNudYfRpzD50tdzwd5JJVEoQrnMcOrG0vPRwAxIKcrBoHHQYvwkyj4OI8d5hOfo fC9Mc8reo21nbwEfUbVMSXfPd0nQzHY= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-645-UhmJbf1EMAOvnloM6pUJQg-1; Fri, 22 Aug 2025 06:23:56 -0400 X-MC-Unique: UhmJbf1EMAOvnloM6pUJQg-1 X-Mimecast-MFC-AGG-ID: UhmJbf1EMAOvnloM6pUJQg_1755858236 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-7e864817cb8so812063485a.0 for ; Fri, 22 Aug 2025 03:23:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755858236; x=1756463036; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eJvTKEyEbzhmekaQhrASqnfJY8OZgIJPjxsG4VBPz2I=; b=kHcCTb8CmnHGbsxOKGR8SIjoPX9BMTlAKS7nJGSMb1e+ufHkFRq+jBbZFhcrzRkLv/ Ai13Z4YqY3xuLFyfhFVDBSr2L5mBLDosz+t83VAyoZiL+pS2lOmXJpiTGTbZqY6C+nEH OfPWKRrkrxG8i3fxvpnEWg2OkIw4AdsHVg1nlUc2F986U3Lsrky/aHOUCszOhgduWSCs 2q/UobKK7ZSwDmhaetQRx5VSEiCl19AaDBgJkEqfTgIYZ/QzShwzrJjV6QGOQUM8ISfq Hh+qnSNIhQD/i4Y/mf40doXL9hF6m8tSMDDAmkNhQVc17Hk7bQbcAuw8PGafrNCZnGjJ mhSw== X-Forwarded-Encrypted: i=1; AJvYcCV7TK2TxocJnjJL/WiMV8I2O4c94HQrLkiUSlbP4GwJPHVrXACBmylKJt9wdZkVqCicMd3FbGXZhARN0xM=@vger.kernel.org X-Gm-Message-State: AOJu0Yyoy0yfZ3b5/aWniORs2vwymqTDaJbmezL/A9mdvqSiKVyrj1eg vbfKvHmtg+qqQ0CqxhFXTBh+HUZNepZuIJ4eUBfGHdhwx/rYZkHAEDnbO9EeySTJ8LP7LE9h8IA pNhUpbBz3M5YRp9RhiJFev81978pvJ1Te6Zyvo2flYY4Mik/vkPYl6ubXgqakarNLdA== X-Gm-Gg: ASbGncs/8Ki3YGzun1BJZdA6ZvD3FLKiSwszhl/7kYy4kU+tQUip6FWQakQZ7K8oDqo vsVMSAqhrfPh3o9hZ+mb/VejqpmEjKARTHgJoeSoexJRMSqxKi7EQn0N3EKymZmV4hYlVW6JAHq 8/NnQipoeTokMtGbv4craA2WsJz0SltUjCVApqN3Yc2Yv0shahXN8TXqLhzU1Ea+Ve3cJTmtY/z 58Ncn9za5+7OmczsN7L1Fn7LlXoWTki6QhMRB3ZAbp/JWOR0DLCB+70qgm2OTJ8w+VY3TXHgJ+o YHR7r5XAhNQEZbER/x1QehrC4MsJuxHbNoO5MY8+50Wk9HJ0qEF2C6c1zPrioARISNxpg0NlnCF 56ZyIokclGVsNuEg+rsI= X-Received: by 2002:a05:620a:2985:b0:7ea:61e:3ce with SMTP id af79cd13be357-7ea11515112mr250142985a.4.1755858235958; Fri, 22 Aug 2025 03:23:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGzbF5my1f7sWP1hvt+Ae8lWAWkUFPWkmMGpX8yUvMXDR4PmNo9Qp3wmQyKLcPE30uIWwQ98Q== X-Received: by 2002:a05:620a:2985:b0:7ea:61e:3ce with SMTP id af79cd13be357-7ea11515112mr250139985a.4.1755858235417; Fri, 22 Aug 2025 03:23:55 -0700 (PDT) Received: from x1 (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7eb1123ce2asm16520885a.65.2025.08.22.03.23.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Aug 2025 03:23:54 -0700 (PDT) Date: Fri, 22 Aug 2025 06:23:52 -0400 From: Brian Masney To: Tudor Ambarus Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Griffin , =?iso-8859-1?Q?Andr=E9?= Draszik , Michael Turquette , Stephen Boyd , Krzysztof Kozlowski , Alim Akhtar , Sylwester Nawrocki , Chanwoo Choi , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, willmcvicker@google.com, kernel-team@android.com Subject: Re: [PATCH 3/3] clk: samsung: add Exynos ACPM clock driver Message-ID: References: <20250819-acpm-clk-v1-0-6bbd97474671@linaro.org> <20250819-acpm-clk-v1-3-6bbd97474671@linaro.org> <720799b1-04ce-46da-b643-1adbdfc661e6@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <720799b1-04ce-46da-b643-1adbdfc661e6@linaro.org> User-Agent: Mutt/2.2.14 (2025-02-20) Hi Tudor, On Fri, Aug 22, 2025 at 09:14:03AM +0100, Tudor Ambarus wrote: > On 8/21/25 7:34 PM, Brian Masney wrote: > > On Tue, Aug 19, 2025 at 11:45:38AM +0000, Tudor Ambarus wrote: > >> +static long acpm_clk_round_rate(struct clk_hw *hw, unsigned long rate, > >> + unsigned long *parent_rate) > >> +{ > >> + /* > >> + * We can't figure out what rate it will be, so just return the > >> + * rate back to the caller. acpm_clk_recalc_rate() will be called > >> + * after the rate is set and we'll know what rate the clock is > >> + * running at then. > >> + */ > >> + return rate; > >> +} > > > > ... > > > >> + > >> +static const struct clk_ops acpm_clk_ops = { > >> + .recalc_rate = acpm_clk_recalc_rate, > >> + .round_rate = acpm_clk_round_rate, > >> + .set_rate = acpm_clk_set_rate, > >> +}; > > > > The round_rate clk op is deprecated. Please convert this over to use > > determine_rate. > > I can do that, sure. Shall I also update the kdoc for round_rate(), mark it > as deprecated and add your Suggested-by tag? It would help other newcomers. I am working to remove round_rate from the clk core and the various drivers. Your driver just needs to be updated similar to this: https://lore.kernel.org/all/20250710-clk-imx-round-rate-v1-10-5726f98e6d8d@redhat.com/ Brian