linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: yangshiguang1011@163.com
Cc: harry.yoo@oracle.com, vbabka@suse.cz, akpm@linux-foundation.org,
	cl@gentwo.org, rientjes@google.com, roman.gushchin@linux.dev,
	glittao@gmail.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org,
	yangshiguang <yangshiguang@xiaomi.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH v3] mm: slub: avoid wake up kswapd in set_track_prepare
Date: Mon, 25 Aug 2025 13:40:07 +0100	[thread overview]
Message-ID: <aKxZp_GgYVzp8Uvt@casper.infradead.org> (raw)
In-Reply-To: <20250825121737.2535732-1-yangshiguang1011@163.com>

On Mon, Aug 25, 2025 at 08:17:37PM +0800, yangshiguang1011@163.com wrote:
> Avoid deadlock caused by implicitly waking up kswapd by
> passing in allocation flags.
[...]
> +	/* Preemption is disabled in ___slab_alloc() */
> +	gfp_flags &= ~(__GFP_DIRECT_RECLAIM);

If you don't mean __GFP_KSWAPD_RECLAIM here, the explanation needs to
be better.

  reply	other threads:[~2025-08-25 12:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-25 12:17 [PATCH v3] mm: slub: avoid wake up kswapd in set_track_prepare yangshiguang1011
2025-08-25 12:40 ` Matthew Wilcox [this message]
2025-08-25 15:42   ` Vlastimil Babka
2025-08-27  5:17     ` Harry Yoo
2025-08-27  7:45       ` yangshiguang
2025-08-27  8:40         ` Vlastimil Babka
     [not found]           ` <4d271e7e.6bea.198f596bd15.Coremail.yangshiguang1011@163.com>
2025-08-29 13:08             ` Vlastimil Babka
2025-08-30  1:48               ` yangshiguang
2025-08-27  8:00       ` Vlastimil Babka
2025-08-27  8:44         ` Vlastimil Babka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aKxZp_GgYVzp8Uvt@casper.infradead.org \
    --to=willy@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=cl@gentwo.org \
    --cc=glittao@gmail.com \
    --cc=harry.yoo@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rientjes@google.com \
    --cc=roman.gushchin@linux.dev \
    --cc=stable@vger.kernel.org \
    --cc=vbabka@suse.cz \
    --cc=yangshiguang1011@163.com \
    --cc=yangshiguang@xiaomi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).