From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-182.mta0.migadu.com (out-182.mta0.migadu.com [91.218.175.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD30DF9CB for ; Mon, 25 Aug 2025 21:38:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756157937; cv=none; b=jqR1nKBQFguwWac6OE2jFiSR3sORJmYnAW4NKCsxSJqScajUbU3Dj30CtdF0DJUEjB8QCOZZRnYPS5ueKw5AI9XxuQb7X4CFkF8M5fWkPIlwjNAEw2sIk3U4FPvjYHpeva2PhpKHQGo7VBoqH2hr7Oym7x4TKacpTx/ZvNhGAD0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756157937; c=relaxed/simple; bh=nDzVpC+t1U+7sHNaEIwZiniHiB4Gcj9beJV5ErzYl1w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=F+zZ3JNPFGFLbifhli6QzJ6rJWDJpm01o98obyw7IyAHDgy6YnSUEALHvxgQ7/4MIYeHJNUuRnL1h98UeNBTwFFgfCou3B58UAu9cZ9uJAyFsdO81GgPDHE3y5X4BPc4jbjSdqU2e3/Uom1lgju7bEyhyZd+e1BAWKLSJi2pYD4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=dKKl258e; arc=none smtp.client-ip=91.218.175.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="dKKl258e" Date: Mon, 25 Aug 2025 14:38:31 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1756157923; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Svt/1wXouXBpITE7xnGEFoLKgtvLf25+nxzKUnLuc7E=; b=dKKl258ebLK0JjJ6bmMPG+Q9KnsfJP84OX4Vb2wogABy/Psyhw6QcqPnO3eDUhaDPxbQbm n+2GkQ1imRGLIht5eNvDOSaEso+pt4GQihzHD00PJUSCxKfbQLM/3rGk6MNZQ4rw9yzjpy jnjs6mBksPP1oNFazsyPiV16vKR/L2c= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Sean Christopherson Cc: Marc Zyngier , Sebastian Ott , Paolo Bonzini , Shuah Khan , kvm@vger.kernel.org, kvmarm@lists.linux.dev, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: selftests: fix irqfd_test on arm64 Message-ID: References: <20250825155203.71989-1-sebott@redhat.com> <87zfbnyvk9.wl-maz@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT On Mon, Aug 25, 2025 at 02:11:30PM -0700, Sean Christopherson wrote: > On Mon, Aug 25, 2025, Marc Zyngier wrote: > > On Mon, 25 Aug 2025 20:52:21 +0100, > > Sean Christopherson wrote: > > > Is there a sane way to handle vGIC creation in kvm_arch_vm_post_create()? E.g. > > > could we create a v3 GIC when possible, and fall back to v2? And then provide a > > > way for tests to express a hard v3 GIC dependency? > > > > You can ask KVM what's available. Like an actual VMM does. There is no > > shortage of examples in the current code base. > > Right, by "sane" I meant: is there a way to instantiate a supported GIC without > making it hard/painful to write tests, and without having to plumb in arm64 > specific requirements to common APIs? > > E.g. are there tests that use the common vm_create() APIs and rely on NOT having > a GIC? Instead of stuffing a GIC in behind vm_create(), I'd rather we have a specific helper for creating a VM with an irqchip. There's tests in arm64 that rely on all this generic infrastructure and also need to select / dimension a GIC appropriately for the test. The majority of selftests don't even need an irqchip anyway. Thanks, Oliver