From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2087.outbound.protection.outlook.com [40.107.243.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A5C521CA02; Thu, 28 Aug 2025 15:08:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.243.87 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756393730; cv=fail; b=THtxrts0Eb9yMhfUxXaKz5Pi9KltVIfFc1O1XcSs7PuSXtQob3qnur1wWsxNRbalN2R4Issmu1GB0ZTA8YbPDYixjx8j8Nxeah1zF8jNDR9gR3gTH0tny37vlBgucxHGxPwfrkg1c8oifilW+No0KtWu39bbrxle+udDgrqDtjo= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756393730; c=relaxed/simple; bh=zbpc2dRpsDJq4cK07egK3VMVvs7phe7nvw2RSA+eqR4=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kI1h/IX9zrYYCFm6/DxtSDWsVmgCRAiPaPdf0ITAo2S4v365FMUHrBLb770KSIdYFGHNmE2A/7OBogQ1l7jNr1R1plMSp2/M22POqiWasoTC1rBG6pdsb7npJD9m0WPG0fMd2HYDsooptpjPjZiKWcOtggC1eaTQhIIPzmHXLTk= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=j0ctJCbn; arc=fail smtp.client-ip=40.107.243.87 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="j0ctJCbn" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=oNCJVQxUSKNq4tabxsNWNaRMP/pfU5scCzB1d8ZbVKxI5QTdo0/gAKZ72IFOyDIYfDUbqxEHvYrPGSxvVvsW7WXyHYhXrQWLCY9p1WJ/zHmwoTCL2X1goO4hhIrE04gtevJueHbvVoB78UOUt731ABX+LEGRGXdcIs/Bav/QYsA8WwTNhixExJz0T04pgTMJv9RZ72cGebNY0hRNSOihtonwSlKite6zWsta8nuMH9HOExLkq4h/DsB6z+pFtfl44dFUlzsLedrqRklw+8hvE2JhHpJ/Ib6EYDFv8pcULoBUThdb3t0G2bq2fGQGt0umIj7hxmDh9tKDm3OSYbEvHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b/15TLv9zzuNxe7/fx6McdV+ZXtXTckksQgFN8JCIc4=; b=dGUFAQNLRVuj3ECa/rdCtmPekxdu1682nX5K3ivGmJkLssH9VPLZJ+bHy7yrLpIKOBCwcJJ4/VbrYuiCNce54m1hXAeFA23iEp25s0U4DKHZueTaLnQuz8zhBnWS1UMivNo61KGldnKc1hfspg23mx0DI5pR3wQbzMK7ZXbcG/WpILEqMQ5h1XUKO5G3kwAHGGbRDMxWdfj9Mgz6BxQoO4oa18x9EMDkFD73u/eMG+3x7W4YsUPnDCMqr+E+hmP4Y8CK+fbOXxOJP7C0tuNdWH4RofJyvT59aAMAyR3lwMDHthjMkTgkwRyX3npIIQBLiD1AQf/9rcttA6k1Ft3x6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=lists.linux.dev smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b/15TLv9zzuNxe7/fx6McdV+ZXtXTckksQgFN8JCIc4=; b=j0ctJCbn2gyjguogGApv1vCeMlgFDp3X3ic2BEIWDBSUVza7lNtP4MqiTMVjPZSrAiJZ72Ulzgz7tFX6PIxKT5qqG5o9S4FbW29qkfqnoh54dip8ADot5vdxbT1Biv3e8Mfud0W6XMw7aocvceCA9oTV3NkkiloBg9FKGKfXCfJWZKU3sFVtqVGdGCUV94Jslpa+37VOx1za5Xwsty4WmLKGYsQTE/Qw2ZKRvGydtoasSkV9LH8QOKhe3jalLMP7fcjjqQI2eGpLZ5YHZ55u9fYFVJgHG7ENrm0KKKZImwyFtABAf4kV1xO8GB8pgXrBFoNohptDFwbvXHFSF8WrQg== Received: from PH7P220CA0064.NAMP220.PROD.OUTLOOK.COM (2603:10b6:510:32c::8) by DS7PR12MB5838.namprd12.prod.outlook.com (2603:10b6:8:79::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9073.13; Thu, 28 Aug 2025 15:08:42 +0000 Received: from SJ1PEPF000026CA.namprd04.prod.outlook.com (2603:10b6:510:32c:cafe::cc) by PH7P220CA0064.outlook.office365.com (2603:10b6:510:32c::8) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9073.18 via Frontend Transport; Thu, 28 Aug 2025 15:08:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SJ1PEPF000026CA.mail.protection.outlook.com (10.167.244.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9073.11 via Frontend Transport; Thu, 28 Aug 2025 15:08:39 +0000 Received: from rnnvmail203.nvidia.com (10.129.68.9) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Thu, 28 Aug 2025 08:08:17 -0700 Received: from rnnvmail203.nvidia.com (10.129.68.9) by rnnvmail203.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Thu, 28 Aug 2025 08:08:16 -0700 Received: from Asurada-Nvidia (10.127.8.14) by mail.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14 via Frontend Transport; Thu, 28 Aug 2025 08:08:14 -0700 Date: Thu, 28 Aug 2025 08:08:13 -0700 From: Nicolin Chen To: Jason Gunthorpe CC: Ethan Zhao , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v3 5/5] pci: Suspend iommu function prior to resetting a device Message-ID: References: <3749cd6a1430ac36d1af1fadaa4d90ceffef9c62.1754952762.git.nicolinc@nvidia.com> <550635db-00ce-410e-add0-77c1a75adb11@gmail.com> <20250821130741.GL802098@nvidia.com> <20250822140821.GE1311579@nvidia.com> <20250828125149.GD7333@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20250828125149.GD7333@nvidia.com> X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF000026CA:EE_|DS7PR12MB5838:EE_ X-MS-Office365-Filtering-Correlation-Id: 6876a271-1d93-4db5-450e-08dde644c53c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|7416014|376014|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Ftz9oIhoxyiiE8b4f5blMj7yMYMLfJjAw//2AGpG9smkaW9PGZ4HD2jhuHw3?= =?us-ascii?Q?dldCfZrxffrgUiIQNHM1mF3VPUlsLlPHs3Xifv8PT02r/TYRqj6mEBskVPPa?= =?us-ascii?Q?+bhZDcOw3vPXvNldBy+aoSTxCnF7ceUeuLOurgwzDHHQk2F8QYORpNNpja4n?= =?us-ascii?Q?3yZn0cG8THGpRGnd3+eZMsqaUSW6bhI8lojtBaIgSuseEk2KAL3Fv35Fh7oG?= =?us-ascii?Q?o8Ktxy3MY3/bELl8syTZr+odTO6eHR1Kr/LJ9wV/oRDyLBsU3FRtYl2iyUMH?= =?us-ascii?Q?cx+6d+OQEXROz2BgrCKhi0T1W1PWlrl+821/m7wC/PhGEonR6C0xnWnrEKNg?= =?us-ascii?Q?hEO8pF4cneH7ptw6xXHRsOF9rOcNgTfN9QmN9iphPoX0IHmn8M9kTKq3SZix?= =?us-ascii?Q?zmaEpKkpmgU2mHqHZM+jVFgvju0+MLYnqGxbY0pTXDmI/r63MovXN3DrhsIO?= =?us-ascii?Q?rpuNWl/uJyB/3s3qbVx+QBM1MjJTjZKmUpkZ5pugQPB6S2Uw4T+JPTndDc+m?= =?us-ascii?Q?imWjMXN+Hul3ENwYt42pzoQPnDoeus5S/d6pVGsU5DCzU7xcDG2B+ONyxv3e?= =?us-ascii?Q?80+trG6kSp209GDncVPZRbl0hbXUyeb18ZbZ3KBhDs5XOhyumRJQim0IUAg2?= =?us-ascii?Q?CCprfvWKygwgxZwl+CsRhNOR/sY9e7XI7vMxe2T7TUoUOl5PTaqzJTYCKR8f?= =?us-ascii?Q?ifD1Fbl6GKwxXz7EpIRhlRaVihW9nKkYJT4b0zYkh0HqixrLWLM9W6LZ7b5D?= =?us-ascii?Q?3bqCGDbJuJ9RVblurgLkV0BO2gmIDrkll3NZGz1fmbJzI/kblS1ZmWdxVJnI?= =?us-ascii?Q?zz2VPJJdRQ+xjIgYk9YdZRhv8uXK5CQhSomdI0MBvq5FaqotDtREIi5VzGvl?= =?us-ascii?Q?qftV/eiuN5haOxQ+I3+OLiQZx9H9TdlgrSHiMWzqwu+Oe7dv1dEs/Pcmdvlu?= =?us-ascii?Q?DejpWJaWAWzbP5bALdO06unPUmQmsNCejrCK0WfobnPjyNHJ4xIJ2PWSrk6P?= =?us-ascii?Q?grDqQQR75wGqsD+gcQoe4zybOMGEKspD/Wbxh9935Gm89Og6EOue5i5REDVj?= =?us-ascii?Q?ud/TUlQmkuoieOSPHVnkSim8CrBulEi5vL4wO3IjkB5+BYoJL/N2bW6F+GtX?= =?us-ascii?Q?xprCoWtPu4ww1GhDP8zP4uS0roo2tLCg/5hHjfV3gjWQ9oUV+G8AdkH9LEZo?= =?us-ascii?Q?zC1Ze4YPRM4KtQKWNlmqIXG0BS6NsDduFGGuRPKKM8NP6slPnHGr+oLrCgp/?= =?us-ascii?Q?GECol9npPhKw3Dyi2wsklZ0jXqkyAtC8Q7HGjy/G4TZZpfEuta45zkII2kui?= =?us-ascii?Q?q+Qtq/cPhmW7escwhK0grhj3/G6D0yI02DzO0Pj51ltrSK6Hcz/FwAAPmieH?= =?us-ascii?Q?XNnH0twkXCwr7/kovMymWRetkpRo84EnvK3BEXeoo5mW8dJXRGqnKwgfbnyA?= =?us-ascii?Q?CYqf+ueWW6tyutzvqFEFknyAAD1nIxo2GHK//UD/ZCSirIlR5eI5S4Aw2gJu?= =?us-ascii?Q?KqZQmNkSZno99ZgGBaoU9Zq2GEoUctpKQ+qp?= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(7416014)(376014)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2025 15:08:39.6464 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6876a271-1d93-4db5-450e-08dde644c53c X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF000026CA.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5838 On Thu, Aug 28, 2025 at 09:51:49AM -0300, Jason Gunthorpe wrote: > On Fri, Aug 22, 2025 at 11:50:58AM -0700, Nicolin Chen wrote: > > > It feels like we need a no-fail re-attach operation, or at least an > > unlikely-to-fail one. I recall years ago we tried a can_attach op > > to test the compatibility but it didn't get merged. Maybe we'd need > > it so that a concurrent attach can test compatibility, allowing the > > re-attach in iommu_dev_reset_done() to more likely succeed. > > This is probably the cleanest option to split these things Yea, that could avoid failing a concurrent attach_dev during FLR unless the dryrun fails, helping non-SRIOV cases too. So, next version could have some new preparatory patches: - Pass in old domain to attach_dev - Add a can_attach_dev op Thanks Nicolin