From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: andrew@lunn.ch, hkallweit1@gmail.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
richardcochran@gmail.com, Parthiban.Veerasooran@microchip.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v4 2/2] net: phy: micrel: Add PTP support for lan8842
Date: Fri, 29 Aug 2025 11:15:54 +0100 [thread overview]
Message-ID: <aLF92l2Sbl2elYBn@shell.armlinux.org.uk> (raw)
In-Reply-To: <20250829062654.mr7fos3yp63d2wjv@DEN-DL-M31836.microchip.com>
On Fri, Aug 29, 2025 at 08:26:54AM +0200, Horatiu Vultur wrote:
> The 08/28/2025 09:27, Russell King (Oracle) wrote:
> > On Thu, Aug 28, 2025 at 09:34:25AM +0200, Horatiu Vultur wrote:
> > > @@ -457,6 +457,9 @@ struct lan8842_phy_stats {
> > >
> > > struct lan8842_priv {
> > > struct lan8842_phy_stats phy_stats;
> > > + int rev;
> >
> > Maybe make this a u16 and move it at the end of the struct?
>
> Yes, I can make it u16 and move it at the end.
> Just for understanding, do you want to move it at the end not to have
> any holes in the struct?
Correct. It makes sense to avoid holes where it doesn't detract from
readability.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
prev parent reply other threads:[~2025-08-29 10:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-28 7:34 [PATCH net-next v4 0/2] net: phy: micrel: Add PTP support for lan8842 Horatiu Vultur
2025-08-28 7:34 ` [PATCH net-next v4 1/2] net: phy: micrel: Introduce function __lan8814_ptp_probe_once Horatiu Vultur
2025-08-28 7:34 ` [PATCH net-next v4 2/2] net: phy: micrel: Add PTP support for lan8842 Horatiu Vultur
2025-08-28 8:27 ` Russell King (Oracle)
2025-08-29 6:26 ` Horatiu Vultur
2025-08-29 10:15 ` Russell King (Oracle) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLF92l2Sbl2elYBn@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=Parthiban.Veerasooran@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).