From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: "Jean-François Lessard" <jefflessard3@gmail.com>
Cc: Andy Shevchenko <andy@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] docs: ABI: auxdisplay: document linedisp library sysfs attributes
Date: Tue, 2 Sep 2025 13:59:38 +0300 [thread overview]
Message-ID: <aLbOGg06ZHkRpDNr@smile.fi.intel.com> (raw)
In-Reply-To: <20250901020033.60196-6-jefflessard3@gmail.com>
On Sun, Aug 31, 2025 at 10:00:29PM -0400, Jean-François Lessard wrote:
> Add ABI documentation for sysfs attributes provided by the line-display
> auxdisplay library module. These attributes enable text message display and
> configuration on character-based auxdisplay devices.
>
> Documents previously undocumented attributes:
> - message, scroll_step_ms (introduced in v5.16)
> - map_seg7, map_seg14 (introduced in v6.9)
>
> Documents newly added attribute:
> - num_chars (targeted for v6.18)
>
> The line-display library is used by multiple auxdisplay drivers and
> can expose these attributes either on linedisp.N child devices or
> directly on parent auxdisplay devices.
Can you split to two? Document undocumented but existing ones (as the first
patch in the series) and only add a num_chars when it's implemented?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-09-02 10:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-01 2:00 [PATCH 0/5] auxdisplay: linedisp: support attribute attachment to auxdisplay devices Jean-François Lessard
2025-09-01 2:00 ` [PATCH 1/5] auxdisplay: linedisp: encapsulate container_of usage within to_linedisp Jean-François Lessard
2025-09-01 2:00 ` [PATCH 2/5] auxdisplay: linedisp: display static message when length <= display size Jean-François Lessard
2025-09-02 10:03 ` Andy Shevchenko
2025-09-02 17:12 ` Jean-François Lessard
2025-09-01 2:00 ` [PATCH 3/5] auxdisplay: linedisp: add num_chars sysfs attribute Jean-François Lessard
2025-09-02 10:04 ` Andy Shevchenko
2025-09-02 17:15 ` Jean-François Lessard
2025-09-01 2:00 ` [PATCH 4/5] auxdisplay: linedisp: support attribute attachment to auxdisplay devices Jean-François Lessard
2025-09-02 10:18 ` Andy Shevchenko
2025-09-02 17:37 ` Jean-François Lessard
2025-09-03 10:18 ` Andy Shevchenko
2025-09-03 11:31 ` Jean-François Lessard
2025-09-01 2:00 ` [PATCH 5/5] docs: ABI: auxdisplay: document linedisp library sysfs attributes Jean-François Lessard
2025-09-02 10:59 ` Andy Shevchenko [this message]
2025-09-02 17:42 ` Jean-François Lessard
2025-09-02 11:00 ` [PATCH 0/5] auxdisplay: linedisp: support attribute attachment to auxdisplay devices Andy Shevchenko
2025-09-02 17:44 ` Jean-François Lessard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLbOGg06ZHkRpDNr@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=geert@linux-m68k.org \
--cc=jefflessard3@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).