Re: [PATCH] thermal: hwmon: replace deprecated strcpy() with strscpy()

[Osama Abdelkader <osama.abdelkader@gmail.com>]

On Wed, Sep 03, 2025 at 01:50:03PM +0200, Rafael J. Wysocki wrote:
> On Mon, Sep 1, 2025 at 5:06 PM Osama Abdelkader
> <osama.abdelkader@gmail.com> wrote:
> >
> > strcpy() is deprecated; use strscpy() instead.
> 
> So why is it better to use strscpy() in this particular case?

Thanks for the review. Technically, there is no change since both have const buf size,
it's just for consistency with other drivers.

Regards,
Osama

> 
> > Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
> > ---
> >  drivers/thermal/thermal_hwmon.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/thermal/thermal_hwmon.c b/drivers/thermal/thermal_hwmon.c
> > index 0ecccd4d8556..64cc3ab949fe 100644
> > --- a/drivers/thermal/thermal_hwmon.c
> > +++ b/drivers/thermal/thermal_hwmon.c
> > @@ -96,7 +96,7 @@ thermal_hwmon_lookup_by_type(const struct thermal_zone_device *tz)
> >
> >         mutex_lock(&thermal_hwmon_list_lock);
> >         list_for_each_entry(hwmon, &thermal_hwmon_list, node) {
> > -               strcpy(type, tz->type);
> > +               strscpy(type, tz->type);
> >                 strreplace(type, '-', '_');
> >                 if (!strcmp(hwmon->type, type)) {
> >                         mutex_unlock(&thermal_hwmon_list_lock);
> > --
> > 2.43.0
> >