From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D31A7081F; Thu, 4 Sep 2025 09:47:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756979279; cv=none; b=dEjJGKo4DZBT+fr8RfBk5+wQ8Rvw/0W0Lc+Wk1BfHT0uOUIfGqeKTRpG5hkAuykL7dnQEvZ1LnrdYFUQM1NnZdmxoT/Ev3uUBvkt0TG2HQ/hhtqOexqikW1sHzP7pXIKBAC+qcI3Nbphst5vDp65cexGEN1PsYPvzfw2Roep2hE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756979279; c=relaxed/simple; bh=QDSgMPM/pIsOiE1PCV3Zn9xlxxsgmypyU+SNLu8IyH8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HzW0aThN06InsJ65DNjM94dNiGPkUw0Zol2i/2VUX1JmtX4AziSsFQykNBNqCL8p0EVFqjQnyeqF5u/8G0i3JqV+u+4TSsU+fkd/34X1nIPuiCyaeTCDbywzJLHcUZ00lrQ0S7/aepfrW77XcsFAvLOl6BqqVD5T/rZRKJaIg+c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=kdQv8xyU; arc=none smtp.client-ip=192.198.163.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="kdQv8xyU" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1756979277; x=1788515277; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=QDSgMPM/pIsOiE1PCV3Zn9xlxxsgmypyU+SNLu8IyH8=; b=kdQv8xyUQwBo8ififPgcXAMFKfBqLLAHLU/fBT51h+OcZKKcN8aN0TN1 wFcuAg0J+hsEcUNp/QqHBxl3swkA7kZqQnuB+Vk0iZcSgSnWSjfXfUzb3 r2PPLJSHHbkz/HjNDVXaMxD7A2X11O9zlCPgVPS0fhuez8EWi8zK3lQUM CmXqFHGsMf2X+IS/AlKKQKYzGbKrwyBcKdhCu6+pmJ7u/MNCOiUSjo3+t jShYTnXEBGdf6GeOgyyEAv2+RVmua14M2rcB1IZzsmcROW3HLE6ts9d+1 9sHnQNrF3fOWVfBGpfkW6GrdLeyPuGhj6rAX0p5FeOM63lxCZ0E2vAD71 w==; X-CSE-ConnectionGUID: eSdxrUOVQcOhlhiuCRbOTQ== X-CSE-MsgGUID: 79KJBoDuTGyJztdEDXFLVA== X-IronPort-AV: E=McAfee;i="6800,10657,11542"; a="61945074" X-IronPort-AV: E=Sophos;i="6.18,238,1751266800"; d="scan'208";a="61945074" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Sep 2025 02:47:56 -0700 X-CSE-ConnectionGUID: YqiqTZ1vSFmdgzlccKkiRQ== X-CSE-MsgGUID: 1c9oWbTrRlCtVVVkyqQvHw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.18,238,1751266800"; d="scan'208";a="171724144" Received: from smile.fi.intel.com ([10.237.72.52]) by orviesa007.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Sep 2025 02:47:54 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98.2) (envelope-from ) id 1uu6ZL-0000000BEV4-06n9; Thu, 04 Sep 2025 12:47:51 +0300 Date: Thu, 4 Sep 2025 12:47:50 +0300 From: Andy Shevchenko To: =?iso-8859-1?Q?Beno=EEt?= Monin Cc: Jarkko Nikula , Mika Westerberg , Jan Dabros , Andi Shyti , Thomas Petazzoni , Vladimir Kondratiev , Tawfik Bayouk , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] i2c: designware: use dev_err_probe when probing platform device Message-ID: References: <20250904-i2c-dw-dev-err-probe-v1-1-acca6ffd122e@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250904-i2c-dw-dev-err-probe-v1-1-acca6ffd122e@bootlin.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Thu, Sep 04, 2025 at 10:59:24AM +0200, Benoît Monin wrote: > Add calls to dev_err_probe on error paths that can return -EPROBE_DEFER > when probing platform device. Namely when requesting the reset controller, > when probing for lock support and when requesting the clocks. > > In i2c_dw_probe_master and i2c_dw_probe_slave, called by the platform > probe from i2c_dw_probe, replace the call to dev_err by dev_err_probe > when failing to acquire the IRQ. > > PCI device probing already use dev_err_probe. What I see here is two patches: 1) conversion existing dev_err() to dev_err_probe(); 2) adding messages to some of the plain return $ERR. Can you split with respective justification for each of them? -- With Best Regards, Andy Shevchenko