Re: [PATCH v2 0/5] USB Type-C alternate mode priorities

[Heikki Krogerus <heikki.krogerus@linux.intel.com>]

Hi Andrei,

On Mon, Aug 25, 2025 at 02:57:45PM +0000, Andrei Kuchynski wrote:
> This patch series introduces a mechanism for setting USB Type-C alternate
> mode priorities. It allows the user to specify their preferred order for
> mode selection, such as USB4, Thunderbolt, or DisplayPort.
> 
> A new sysfs attribute named 'priority' is exposed to provide user-space
> control over the mode selection process.
> 
> This series was tested on a Android OS device running kernel 6.16.
> 
> Changes in v2:
> - The priority variable is now a member of the typec_altmode struct
> - typec_altmode2port is used to obtain the typec_port struct pointer
> - Default priorities are now set based on the order of registration
> - The mode_control capability is enabled by default
> - The mode_selection_state struct will be introduced in a separate series
> - svid will be used instead of the typec_mode_type enum
> 
> Andrei Kuchynski (5):
>   usb: typec: Add alt_mode_override field to port property
>   platform/chrome: cros_ec_typec: Set alt_mode_override flag
>   usb: typec: ucsi: Set alt_mode_override flag
>   usb: typec: Implement alternate mode priority handling
>   usb: typec: Expose alternate mode priority via sysfs

I'm sorry for keeping you waiting. I think these are okay - although,
I had to put a few nitpicks :) but they are minor - but can you
include a patch where you use the priority member in a driver (maybe
cros_ec_typec.c)?

thanks,

-- 
heikki