From: Kamaljit Singh <kamaljit.singh@opensource.wdc.com>
To: Keith Busch <kbusch@kernel.org>
Cc: axboe@kernel.dk, hch@lst.de, sagi@grimberg.me,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
cassel@kernel.org, dlemoal@kernel.org, kamaljit.singh1@wdc.com
Subject: Re: [PATCH v1 1/1] nvme-core: exclude ioccsz/iorcsz checks for admin ctrlr
Date: Fri, 5 Sep 2025 15:14:56 -0700 [thread overview]
Message-ID: <aLtg4PIb1Xd6WTP0@ros-3.wdc.com> (raw)
In-Reply-To: <aLta40FO1Ud6TZ4T@kbusch-mbp>
On Fri, Sep 05, 2025 at 03:49:23PM -0600, Keith Busch wrote:
> On Fri, Sep 05, 2025 at 02:10:01PM -0700, Kamaljit Singh wrote:
> > An administrative controller does not support I/O queues, hence it
> > should exclude existing checks for IOCCSZ/IORCSZ.
> >
> > - if (!nvme_discovery_ctrl(ctrl) && ctrl->iorcsz < 1) {
> > + if (!nvmf_discovery_ctrl(ctrl) && !nvme_admin_ctrl(ctrl) && ctrl->iorcsz < 1) {
>
> Excessive line length over 80 chars.
>
> Perhaps, though, we should have a helper to indicate IO controllers
> rather than chaining conditions for everything that isn't one.
Sure, I'll add a new function nvme_is_io_controller() and make it dependent
on nvmf_discovery_ctrl() and nvme_admin_ctrl(). How does that sound?
Thanks,
Kamaljit
prev parent reply other threads:[~2025-09-05 22:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-05 21:10 [PATCH v1 0/1] Preclude IOCCSZ/IORCSZ validation for admin controller connect Kamaljit Singh
2025-09-05 21:10 ` [PATCH v1 1/1] nvme-core: exclude ioccsz/iorcsz checks for admin ctrlr Kamaljit Singh
2025-09-05 21:49 ` Keith Busch
2025-09-05 22:14 ` Kamaljit Singh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLtg4PIb1Xd6WTP0@ros-3.wdc.com \
--to=kamaljit.singh@opensource.wdc.com \
--cc=axboe@kernel.dk \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=hch@lst.de \
--cc=kamaljit.singh1@wdc.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox